question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Run vsx in same container if the container specs match

See original GitHub issue

Is your enhancement related to a problem? Please describe.

As part of https://github.com/eclipse/che/issues/15272 to add support of VS Code Extension Pack, there is a need to have several VS Code extensions running in the same container.

Describe the solution you’d like

Plug-in broker should use only one container for all VS Code extensions specified in a meta.yaml if the plug-in sidecar image is the same.

Example of current meta.yaml for redhat/java11:

...
spec:
  containers:
    - image: "docker.io/eclipse/che-remote-plugin-runner-java11:next"
      name: vscode-java
      memoryLimit: "1500Mi"
      volumes:
      - mountPath: "/home/theia/.m2"
        name: m2
  extensions:
    - https://github.com/microsoft/vscode-java-debug/releases/download/0.20.0/vscode-java-debug-0.20.0.vsix
    - https://download.jboss.org/jbosstools/static/jdt.ls/stable/java-0.50.0-1825.vsix

so if there is VS Code yaml with

repository: https://github.com/redhat-developer/vscode-xml
category: Language
firstPublicationDate: "2019-10-28"
spec:
  containers:
    - image: "docker.io/eclipse/che-remote-plugin-runner-java11:next"
      name: vscode-xml
      memoryLimit: "768Mi"
  extensions:
    - https://github.com/redhat-developer/vscode-xml/releases/download/0.9.1/redhat.vscode-xml-0.9.1.vsix

at the end, we should have only one container using the image docker.io/eclipse/che-remote-plugin-runner-java11:next and 3 vsix files will be provided in this container.

Note: It works only if there is only one container defined or if we use spec/container instead of spec/containers

About the memory limit, for now it could be average or sum of memoryLimit

Describe alternatives you’ve considered

None

Additional context

JDT.ls need to have access to other jars files that are provided through VS code extensions. Also some VS Code extensions may depend on other Extensions at runtime

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
benoitfcommented, Jan 13, 2020

there are already multiple VS code extensions for some plugins

0reactions
che-botcommented, Jul 27, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Multi-platform images | Docker Documentation
When running an image with multi-platform support, docker automatically selects the image that matches your OS and architecture. Most of the Docker Official ......
Read more >
Attach to a running container - Visual Studio Code
To attach to a Docker container, either select Dev Containers: Attach to Running Container... from the Command Palette (F1) or use the Remote...
Read more >
Windows Container Version Compatibility | Microsoft Learn
Version compatibility for containers built from different versions of Windows Server and Windows.
Read more >
Best Practices - Running your application with Amazon ECS
These are the application best practices for Amazon Elastic Container Service to be mindful of when using Amazon ECS in a production environment....
Read more >
VSX-1019AH-K VSX-919AH-K - Pioneer Electronics
If the AC plug of this unit does not match the AC outlet you want to use, the plug must be removed and...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found