[Windows] Building fails for generated che-theia (eclipse-che/theia-generator)

To build my own eclipse-che I followed the steps on https://www.npmjs.com/package/@eclipse-che/theia-generator):

git clone https://github.com/eclipse-theia/theia
cd theia
che-theia init
yarn

Note that I am running this on Windows 10, node version v12.16.3 and yarn version 1.22.4. Should this work?

The yarn operation failed, with the following error for a number of files:

lerna ERR! C:\work\theia\packages\@che-eclipse-che-theia-terminal\src\browser\server-definition\remote-connection.ts
lerna ERR!   1:1  error  missing file header (tslint:file-header)  @typescript-eslint/tslint/config
lerna ERR!
lerna ERR! C:\work\theia\packages\@che-eclipse-che-theia-terminal\src\browser\server-definition\remote-terminal-protocol.ts
lerna ERR!   1:1  error  missing file header (tslint:file-header)  @typescript-eslint/tslint/config
lerna ERR!
lerna ERR! C:\work\theia\packages\@che-eclipse-che-theia-terminal\src\browser\server-definition\terminal-proxy-creator.ts
lerna ERR!   1:1  error  missing file header (tslint:file-header)  @typescript-eslint/tslint/config
...

I did some debugging and found the error seems to be related to the License in the file header:

 * SPDX-License-Identifier: EPL-2.0

If I change this into

 * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0

it does not longer complain. (I found the license-identifier in other src files). I found the following lint rule theia\che\che-theia\generator\tslint.json, but don’t understand why it complain

{
  "defaultSeverity": "error",
  "rules": {
    "file-header": [
      true,
      "SPDX-License-Identifier: EPL-2\\.0"
    ],
    .... 

Any suggestion is welcome. Thanks!

[RomanNikitenko]

@hansbank Hello!

I was still facing an issue with lint, regarding “@typescript-eslint/class-name-casing”: “error”. Not sure why this comes, but I could overcome this by removing the corresponding entry in ./che/che-theia/configs/eslint.theia.errors.json. Is this lint message expected?

Theia bumped eslint related versions to 3.1.0 For 3.0.0 version class-name-casing was replaced by naming-convention: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0

A more serious issue is compilation problem in eclipse-che-theia-plugin-ext (@eclipse-che/theia-plugin-ext), full error trace is given at the end of this comment Is there a way to work-around this so that I can create a build?

As @tsmaeder mentioned:

che-theia master does not build against theia master currently

I’m working on it at the moment to align che-theia master with theia master. As work-around you could try some fixes from https://github.com/eclipse/che-theia/pull/823. For example, errors like:

@eclipse-che/theia-plugin-ext: [compile] src/browser/type-converters.ts(18,40): error TS2305: Module '"../../../../../../node_modules/@theia/plugin-ext/lib/common/plugin-api-rpc"' has no exported member 'ResourceFileEditDto'.
@eclipse-che/theia-plugin-ext: [compile] src/browser/type-converters.ts(19,5): error TS2305: Module '"../../../../../../node_modules/@theia/plugin-ext/lib/common/plugin-api-rpc"' has no exported member 'ResourceTextEditDto'.

should be fixed by https://github.com/eclipse/che-theia/pull/823/commits/7e49ec77960e73e42591caafdbb94449c378244c The alignment with theia master is still in progress. I’ll try to finalize it ASAP.

[che-bot]

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.