helm goal configuration appends ${project.artifactId} to home and sources

Description

Documentation says:

home: The Chart URL for this project’s home page, which is ${project.url} if not provided. sources: The Chart list of URLs to source code for this project, defaults to the list of ${project.scm.url} if not provided.

But reality is that home is set to: ${project.url}/${project.artifactId} and sources to ${project.scm.url}/${project.artifactId}

Info

Eclipse JKube version : 1.0.0-rc-1
Maven version (mvn -v) : 3.6.3

Issue Analytics

State:
Created 3 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

2reactions

hlavkicommented, Aug 31, 2020

thanks @manusa for looking into this behaviour. Then it would be great to have some note about this (multi module project) in documentation.

1reaction

manusacommented, Aug 31, 2020

I don’t particularly see this as a JKube specific bug.

Solution 1

The first and easiest fix would be to complete your helm configuration:

<helm>
    <description>JKube #363</description>
    <home>https://jkube.example.com</home>
    <sources>
        <source>https://github.com/hlavki/jkube-363</source>
    </sources>
    <maintainers>
        <maintainer>
            <name>John Nhoj</name>
            <email>jon.nhoj@example.com</email>
        </maintainer>
    </maintainers>
</helm>

Solution 2

Maybe even with variables defined in the parent pom.xml

<properties>
    <java.version>11</java.version>
    <helm.home>${project.parent.url}</helm.home>
    <helm.source>${project.parent.scm.url}</helm.source>
</properties>

And configuration referencing those variables in assembly/pom.xml

<helm>
    <description>JKube #363</description>
    <home>${helm.home}</home>
    <sources>
        <source>${helm.source}</source>
    </sources>
    <maintainers>
        <maintainer>
            <name>John Nhoj</name>
            <email>jon.nhoj@example.com</email>
        </maintainer>
    </maintainers>
</helm>

Solution 3

Configure inheritance for URL and SCM elements as stated in MNG-6059 (requires newer Maven versions):

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd"
         child.project.url.inherit.append.path="false"
         >
<!-- ... -->
    <url>https://jkube.example.com</url>
    <scm child.scm.url.inherit.append.path="false">
        <connection>scm:git:ssh://git@github.com:hlavki/jkube-363.git</connection>
        <url>https://github.com/hlavki/jkube-363</url>
        <tag>HEAD</tag>
    </scm>
<!-- ... -->
</project>

All of the provided solutions will output the following Chart.yaml, just pick the one that suits you better 😉:

---
name: jkube-boot-multimodule-assembly
home: https://jkube.example.com
sources:
- https://github.com/hlavki/jkube-363
version: 1.0-SNAPSHOT
description: 'JKube #363'
maintainers:
- name: John Nhoj
  email: jon.nhoj@example.com