[Legal] Found IP issue in the Kura port for Windows

Two legal/IP issues have been found in the following commit:

https://github.com/eclipse/kura/commit/741220741bf613a43040afaa890f37f96ccf0c6d

• In kura/distrib/src/main/resources/Win64-nn/Kura_x64.nsi the macro _ReplaceInFile is not an original work by Martin Malik but has been copied from the NSIS web site. No CQ has been filed for this code snippet.
• In target-platform/org.eclipse.kura.windows.launcher/src/main/c/main.c and target-platform/org.eclipse.kura.windows.service/src/main/c/main.c the function str_replace is not an original work of Martin Malik but has been copied from Stack Overflow. No CQ has been filed for this code snippet.

The offending commit above appeared on the Kura develop branch after the latest Kura 2.0.1 release. No Kura release has been issued including this commit.

Martin Malik is working to provide alternative and original implementations of _ReplaceInFile and str_replace to amend the commit above.

@malikm Can you please identify the license for each of the two functions above?

[malikm]

OK then let’s do the following first:

• Replace the offending functions with new ones (there are commits for this already: https://github.com/eclipse/kura/pull/499/commits/73e8e8ab81f17c415fafd28f6161521d0bb4afb6 and https://github.com/eclipse/kura/pull/499/commits/7693bd1b7dc26074cc88b91e398208fe1af4cb74)
• Remove all binary files (DLLs and EXEs) from repo

This should be done by replacing the original Windows commits (https://github.com/eclipse/kura/pull/313 and https://github.com/eclipse/kura/pull/319) with sanitized ones (rebase).

Does everybody agree with this ?

Edit: Oh we have a Like button here as well 😃

[cdealti]

I’ve rewritten the repository history. This can be closed.

git filter-branch --index-filter 'git rm --cached --ignore-unmatch \
./kura/distrib/src/main/resources/Win64-nn/Kura_x64.nsi \
./target-platform/org.eclipse.kura.windows.launcher/src/main/c/main.c \
./target-platform/org.eclipse.kura.windows.service/src/main/c/main.c \
./target-platform/org.eclipse.kura.windows.system/src/main/bin/Win32/x64/KuraNativeWin.dll \
./target-platform/org.eclipse.kura.windows.system/src/main/bin/Win32/x86/KuraNativeWin.dll \
./target-platform/org.eclipse.soda.dk.comm/src/main/c/Release/win32/x64/dkcomm.dll \
./target-platform/org.eclipse.kura.windows.launcher/src/main/bin/Win32/x64/KURALauncher.exe \
./target-platform/org.eclipse.kura.windows.launcher/src/main/bin/Win32/x86/KURALauncher.exe \
./target-platform/org.eclipse.kura.windows.service/src/main/bin/Win32/x64/KURAService.exe \
./target-platform/org.eclipse.kura.windows.service/src/main/bin/Win32/x86/KURAService.exe \
' develop

git push -f origin develop