InMemoryRegistrationStore#addObservation doesn't add the observation

The current code is not adding the observation to the internal data structure, this scenario is not covered in the tests.

As you can see in the current code, the existing observations are being removed and the new observation is not being added:

        try {
            lock.writeLock().lock();
            // cancel existing observations for the same path and registration id.
            for (Observation obs : unsafeGetObservations(registrationId)) {
                if (observation.getPath().equals(obs.getPath()) && !Arrays.equals(observation.getId(), obs.getId())) {
                    unsafeRemoveObservation(obs.getId());
                    removed.add(obs);
                }
            }
        } finally {
            lock.writeLock().unlock();
        }

[sbernard31]

I added some tests about that and found some minor issues about “context”. #430

[AlexITC]

My apologizes, I got confused with how the observations worked, there was a silly mistake in my code.

Thanks.