Some extension resource url return 404 or 500

This package.json urls return 404

https://open-vsx.org/vscode/asset/viper-admin/viper/2.4.0/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/pokey/parse-tree/0.16.0/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/huacat/office-theme/1.1.3/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/unthrottled/doki-theme/74.1.0/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/huacat/pink-theme/0.4.0/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/idleberg/hopscotch/0.8.2/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/PKief/material-product-icons/1.1.2/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/activecove/marquee/2.0.0/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/crystal-lang-tools/crystal-lang/0.8.4/Microsoft.VisualStudio.Code.WebResources/extension/package.json
https://open-vsx.org/vscode/asset/artlaman/chalice-icon-theme/1.2.17/Microsoft.VisualStudio.Code.WebResources/extension/package.json

Also this theme json resources return error 500

https://open-vsx.org/vscode/asset/abelfubu/abelfubu-dark/1.3.4/Microsoft.VisualStudio.Code.WebResources/extension/themes/abelFubu%20Dark+-color-theme.json
https://open-vsx.org/vscode/asset/abelfubu/abelfubu-dark/1.3.4/Microsoft.VisualStudio.Code.WebResources/extension/themes/abelFubu%20Darker+-color-theme.json
https://open-vsx.org/vscode/asset/muchiros/attention-theme/0.0.4/Microsoft.VisualStudio.Code.WebResources/extension/themes/Attention%20Dark-color-theme.json

This is the query to get the above extensions, this query is used in vscode when previewing themes directly from marketplace

curl 'https://open-vsx.org/vscode/gallery/extensionquery' \
  -H 'content-type: application/json' \
  --data-raw '{"filters":[{"criteria":[{"filterType":5,"value":"themes"},{"filterType":8,"value":"Microsoft.VisualStudio.Code"},{"filterType":12,"value":"4096"}],"pageNumber":1,"pageSize":40,"sortBy":0,"sortOrder":0}],"assetTypes":[],"flags":950}' \
  --compressed

Also from this result I found that the publisher.displayname is null, this is required for the quickpick list description

{
  "extensionId": "02f7b704-1474-4f25-b451-a60afbf63dd2",
  "extensionName": "frontend-delight",
  "displayName": "Frontend Delight",
  "shortDescription": "Frontend Delight color scheme for VSCode",
  "publisher": {
    "displayName": null,
    "publisherId": "a5233a78-f3da-4233-91c7-fd4e857007f0",
    "publisherName": "RobinBoers"
  },
  "versions": [
...
  ],
  "tags": [
    "__web_extension",
    "color-theme",
    "theme"
  ],
  "releaseDate": null,
  "publishedDate": null,
  "lastUpdated": null,
  "categories": [
    "Themes"
  ],
  "flags": ""
}

You can also repro 404 errors when previewing product icon themes

cc @amvanbaren @filiptronicek

[amvanbaren]

Also from this result I found that the publisher.displayname is null

Yes, publisher.displayName is not set. https://github.com/eclipse/openvsx/blob/f475efa0495393d6b71cb5512b5a4392afce2115/server/src/main/java/org/eclipse/openvsx/adapter/VSCodeAdapter.java#L363-L365

It looks like some extensions have a displayName that is different than publisherName (namespace name). Winnie Lin: https://marketplace.visualstudio.com/items?itemName=onecentlin.laravel-blade

While for other extensions the displayName is the same as the publisherName. codingyu: https://marketplace.visualstudio.com/items?itemName=codingyu.laravel-goto-view

I can add queryExt.publisher.displayName = namespace.getName(); as a quick fix.

[amvanbaren]

So this should still be fixed in openvsx right?

Yes, I’ve added a /vscode/unpkg/{namespace}/{extension}/{version}/{path} endpoint to VSCodeAdapter. I’ve changed ExtensionProcessor to always get all resources from a vsix package.

The main challenge is to write a database migration that re-processes all extension versions to get all resources from its vsix package. Flyway offers Java migrations besides SQL scripts, so it is possible.