Refactoring of a Promise.all() in opensource.ts

There’s an improvement available here (ideal for first-timers with Promise)

https://github.com/EddieJaoudeCommunity/EddieBot/blob/develop/src/commandHandlers/tips/opensource.ts

/**
 * Set the given embed message with a curated list of tips and resources that help members of the community to
 * contribute to open-source software (OSS).
 */
export const createTip = async (embed: MessageEmbed) => {
  const tips = await Promise.all(
    config.TIPS.tips.map((file) => readMarkdown(file))
  );
  const resources = await Promise.all(
    config.TIPS.resources.map((file) => readMarkdown(file))
  );

  tips.forEach((tip) => embed.addField('Tips :bulb:', tip));
  resources.forEach((resource) =>
    embed.addField('Links and Resources :link:', resource)
  );

It is possible to do something like:

// Use ES6 deconstructing.
// This is actually totally untested and might not actually work, however Promise.all() can work in harmony.
const { tips, resources } = await Promise.all([
  config.TIPS.tips.map((file) => readMarkdown(file)),
  config.TIPS.resources.map((file) => readMarkdown(file))
]);

[stemount]

@BOLT04 EXACTLY!!! Open Source works! Other people can improve on your code suggestions!

What a revelation!!

Only trolling. Absolutely, this looks really neat now. ^^^^^

[eddiejaoude]

I will share this in Discord as it is a good first issue