Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Umbrella Issue for Accessibility Fixes

See original GitHub issue

Description

While adding accessibility tests in PR #2379 , the following issues failed the tests.

All pages:

Add lang attribute to html tag instructions here - #2415
GitHub icon link in nav bar needs aria-label attribute - #2506
Increase contrast ratio for “Powered by EddieHub” (current 2.53, required 4.5)
Increase contrast ratio for “Donate with GitHub Sponsors” (current 2.53, required 4.5)

Home Page

Increase contrast ratio for “Users” purple box (current 2.98, required 4.5) - #2391

Profile Page:

Social icons links need an aria-label
Increase contrast ratio for profile views count (current 3.56, required 4.5)

Profile Links:

Modify UserLink component to use link.icon color only for the Icon. - #2424

Docs Pages:

Add Title tags to all pages - #2496

Issue Analytics

State:
Created 9 months ago
Reactions:1
Comments:20 (17 by maintainers)

Top GitHub Comments

2reactions

EmmaDawsonDevcommented, Dec 26, 2022

I can also chime in here a say that the word icon is not needed here. The screen reader itself will announce that it’s an image and a link so using icon in the label becomes too verbose.

2reactions

dan-mbacommented, Dec 26, 2022

@CBID2 I looked at your change and the aria-label needs double quotes on both sides. aria-label="GitHub Icon"

Also, the PR you opened is against your fork & not the main LinkFree repo In general, avoid line numbers in PR titles, save that for the description section.