Can't re-authenticate with Google/Facebook on app hard-restart

How to reproduce:

1. Login to your account
2. Close the app and remove it from the task view
3. Reopen the app
4. Call reauthenticate()

IS: Error: Not logged in with google or Not logged in with facebook

SHOULD: Re-authenticate

On restart the variables

// firebase.android.js - Line 10,11,12
firebase._rememberedContext = null;
firebase._googleSignInIdToken = null;
firebase._facebookAccessToken = null;

are reset to null. They should be stored in the appSettings.

[witi83]

After reviewing the code base (specifically login) and the firebase documentation, it seems to me that you are correct: Anonymous users have to be linked as well!

However, I’m still curious about two things: First, why this change fixes the ominous FirebaseAuthUserCollisionException, which occured to a couple of people. Obviously, the real reason lies somewhere else. And second, why didn’t we observe the creation of two users as well. This is something I have to investigate.

In the meantime @EddyVerbruggen , feel free to revert it.

Thanks for @RaphaelJenni reporting!

[RaphaelJenni]

This is my code in a condensed way. You can extract the code you want for the README.

const fbase = require('nativescript-plugin-firebase');

//********************************

private static setAuthenticationToken(googleSignInToken: string, facebookSignInToken: string){
        const authTokens: AuthTokens = {
            googleSignInIdToken: googleSignInToken,
            facebookSignInToken: facebookSignInToken
        };
        
	this.secureStorage.set({
                key: UserService.SECURE_STORAGE_AUTH_TOKEN_KEY,
                value: JSON.stringify(authTokens)
            })
        );
}

private static getAuthenticationToken() {
        return JSON.parse(this.secureStorage.get({
                key: UserService.SECURE_STORAGE_AUTH_TOKEN_KEY
          }));
}

private static clearAuthenticationToken$() {
    this.secureStorage.remove({key: UserService.SECURE_STORAGE_AUTH_TOKEN_KEY});
}
	
//********************************
	
this.firebase.login({type: loginType})
   .then(() => UserService.setAuthenticationToken(fbase._googleSignInIdToken, fbase._facebookAccessToken))
			
			
//********************************
	
	
const reAuthenticationOptions = getAuthenticationToken();
	
fbase._googleSignInIdToken = authTokens.googleSignInIdToken;
fbase._facebookSignInToken = authTokens.facebookSignInToken;
	
this.firebase.reauthenticate(/*REAUTHENTICATION OPTIONS*/)