Insufficient error reporting on alpha1

Error is:

  File "/usr/local/lib/python3.7/dist-packages/edgedb/asyncio_con.py", line 71, in fetchone
    query, args, kwargs)
  File "edgedb/protocol/protocol.pyx", line 476, in execute_anonymous
  File "edgedb/protocol/protocol.pyx", line 189, in _parse
edgedb.errors.InternalServerError: 'cookie_id'

The query is:

            WITH
                NewUser := (INSERT User {
                    first_name := <str>$first_name,
                    last_name := <str>$last_name,
                    email := <str>$email,
                    password := <str>$password,
                }),
                NewSession := (INSERT Session {
                    cookie := <str>$cookie_id,
                    expires := <datetime>$expires,
                    user := NewUser,
                })
            SELECT NewUser {
                id
            }

Schema is:

    type User {
        property first_name -> str;
        property last_name -> str;
        required property email -> str {
            constraint exclusive;
        };
        property password -> str;
    }
    type Session {
        required property cookie -> str;
        required property expires -> datetime;
        multi link user -> User;
        index cookie_idx on (__subject__.cookie);
    }

Small change like this:

            WITH
                NewUser := (INSERT User {
                    first_name := <str>$first_name,
                    last_name := <str>$last_name,
                    email := <str>$email,
                    password := <str>$password,
                }),
                NewSession := (INSERT Session {
                    cookie := <str>$cookie_id,
                    expires := <datetime>$expires,
                    user := NewUser,
                })
            SELECT NewSession {
                cookie
            }

makes query working. I’m not sure if the query actually makes sense. I originally wanted to do two inserts and return data from the first one. I guess there is some pruning of unused variables going on…

Edgedb version is alpha1 from the distribution. Not sure if it’s fixed in master.

[1st1]

Some context on closing this: correct protocol implementation would guard against sending incorrect number of arguments or types. The server should react in a relatively nice way if it wasn’t the case, but right now we lack proper testing infrastructure to add tests for that. We’ll deal with this and many other scenarios when we start investing into proper low-level protocol testing infra.

[elprans]

The WITH clause, unlike in SQL is purely declarative, so if you don’t refer to the declared query, it never gets executed. The KeyError on the parameter name is a bug for sure.