Type annotations
See original GitHub issueHi!
First, thanks for all the great work on EdgeDB. The Python driver looks fab, and I especially like the built-in async support.
Problem description
From what I’ve seen, edgedb-python
public-facing APIs do not provide type annotations. I discovered this by using edgedb.async_connect()
and wondering why my editor wouldn’t autocomplete the con
object.
Proposed solution
Since edgedb-python
is targeting Python 3.6+, I believe it should fully embrace type hints. Adding these would add a lot in terms of IDE support and developer productivity.
Implementation ideas If not, I’d be very glad to give a helping hand adding these to the library. The PR might be quite big — should we consider splitting the work by tackling public-facing APIs only first? Let me know!
Issue Analytics
- State:
- Created 4 years ago
- Reactions:2
- Comments:10 (9 by maintainers)
Top GitHub Comments
You aren’t interrupting it, are you? If may appear to hang after that message, but it’s not, the parsers are getting built and that takes a while.
Feel free to go ahead and submit a PR! We can then release an updated version shortly.