v5 menu select fails to update when menu is deleted

Describe the bug I want just to report that probably this method needs some little exception handling, maybe just wrap it with a try/catch

menu.select(...
   set: async (ctx, selectedKey) => {
       // do stuff, like update cache, remote server values...
       // Now I need to close the menu. I am using this method (although I tried with ctx.deleteMessage() and it's just the same)
       await deleteMenuFromContext<Context>(ctx);
   })

This leads to unhandled promise rejection

(node:21113) UnhandledPromiseRejectionWarning: Error: 400: Bad Request: message to edit not found
    at /home/lamuertepeluda/Development/my-awsome-bot/node_modules/telegraf/core/network/client.js:281:17
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Promise.all (index 0)
    at async MenuMiddleware.editMenuOnContext [as _sendMenu] (/home/lamuertepeluda/Development/my-awsome-bot/node_modules/telegraf-inline-menu/dist/source/send-menu.js:55:13)
    at async /home/lamuertepeluda/Development/my-awsome-bot/node_modules/telegraf-inline-menu/dist/source/menu-middleware.js:69:17
(node:21113) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:21113) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Versions Did you updated telegraf and telegraf-inline-menu to the latest version? “telegraf”: “^3.38.0”, “telegraf-inline-menu”: “^5.0.0-beta.5”, “telegraf-session-redis”: “^5.1.0”, “telegraf-stateless-question”: “^0.1.1”, “telegram-format”: “^2.0.0”

What version of NodeJS (and TypeScript) do you use?

• Version of NodeJS: 12.18.0
• Version of TypeScript: 3.9.3

[lamuertepeluda]

Hi @EdJoPaTo , it works fine now: no exception thrown. Thank you.

[EdJoPaTo]

I thought I already responded to this one… sorry about that.

Not the deletion of the message throws the error. The error is throws when the menu tries to do the job: showing the selection to the user by updating the menu. Updating a message which isnt there anymore. The error happens within the MenuMiddleware, more precisely within the editMenuOnContext function called by the MenuMiddleware. Its always a good idea to catch possible errors with bot.catch.

Taking a look about your choices towards the user close seems like a ‘non’ choice, something different. From only knowing that I would tend towards using a different button for that besides the selection / user choice.

select is basically a specific way of a choose: let the user choose something but also show the user afterwards what was done. If you dont want to use the feature of the select and do it yourself / differently then just stick to the more generic method choose there.