question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add a few special metrics in symbolic module

See original GitHub issue

🐞 Problem Yes, I’m talking about Schwarzschild metric & possibly, Kerr metric.

💡 Possible solutions

  • These can be separate classes inheriting from Metric class, or just functions returning an object of the Metric class. Open to discussion

📋 Steps to solve the problem

  • Comment below about what you’ve started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:15 (15 by maintainers)

github_iconTop GitHub Comments

1reaction
OVSofiacommented, Jun 24, 2019

I do it like this

1reaction
ritzvikcommented, Jun 24, 2019

In my opinion the best option is the second (Just functions). But why they shouldn’t be functions of the class ChristoffelSymbols(Tensor) ? (That’s how I did it)

That’s what I was thinking, functions are best. They should be functions returning instances of MetricTensor(Tensor) and not be functions inside the class, so that the classes do not lose their generality.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Add loads of predefined metrics in symbolic module · Issue #309 ...
Have predefined metrics in symbolic module Steps to solve the problem Comment below about what you've started working on. Add, commit, push your...
Read more >
Add a few special metrics in symbolic module #244 - Issuehunt
Problem Yes, I'm talking about Schwarzschild metric & possibly, Kerr metric. Possible solutions. These can be separate classes inheriting from Metric ...
Read more >
Symbolic Relativity Module - EinsteinPy
Symbolic Relativity Module¶ · Predefined Metrics · All Available Metrics · find · Helper Function and Classes · Symbolic Constants Module · Tensor...
Read more >
metricbeat.reference.yml - Elastic
The following reference file is available with your Metricbeat installation. It shows all non-deprecated Metricbeat options. You can copy from this file and ......
Read more >
Experimenting with documentation coverage metrics - a few ...
This particular library has a dependency to another library (ZippyJSON), and I didn't want to include it's symbols into my coverage metrics.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found