question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rename UseElasticApm extension methods

See original GitHub issue

From elastic/apm-agent-dotnet#230

Currently we have 2 UseElasticApm methods and this is very confusing. There seems to be an agreement to rename those to better reflect their purposes.

This comment describes what those do.

Suggestions (from @SergeyKleyman 's comment)

  • Elastic.Apm.AspNetCore.UseElasticApm -> Elastic.Apm.AspNetCore.UseElasticApmBase
  • Elastic.Apm.All.UseElasticApm -> Elastic.Apm.All.UseAllElasticApm

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
gregkalaposcommented, May 22, 2019

But isn’t having AspNetCore in the Elastic.Apm.All misleading? AspNetCore is just 1 part of it, it also starts monitoring EFCore and HttpClient. I would prefer not to have AspNetCore in that method name.

0reactions
gregkalaposcommented, Jul 9, 2019

Implemented in #371.

Read more comments on GitHub >

github_iconTop Results From Across the Web

NET Agent version 1.x
Hosting package with an extension method on IHostBuilder #537 ... Based on feedback we also renamed the UseElasticApm() method in the Elastic.
Read more >
extension method as a way to rename property
Some class has ugly field called URL, but Id rather call it file. ... Is there any way to not use setFile, but...
Read more >
Elasticsearch Best Practices - Alibaba Cloud
1.Overview of best practices. 2.Elasticsearch migration. 2.1. Migrate data between Alibaba Cloud Elasticsearch clusters. 2.1.1. Use the reindex ...
Read more >
apm-agent-java 请填写此调查以帮助我们优先考虑框架支持 ...
It is an extension that must be installed in your PHP environment. jar. ... The docker Based on feedback we also renamed the...
Read more >
How to deploy an app from circleCI to aws eb
eb init creates a file at location - ./elasticbeanstalk/config.yml . Perhaps you can try adding that manually and see if it works ....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found