Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

add support for reactive Spring WebClient instrumentation

See original GitHub issue

Is your feature request related to a problem?

Webflux provides a client that allows to communicate with other reactive services.

While server-side instrumentation is covered with elastic/apm-agent-java#1305 , the client part is not part of it.

Describe the solution you’d like

instrument Webflux client
capture external HTTP requests as spans and link them to the active transaction.
should support the two available implementations: reactor/netty and jetty
add context-propagation headers to HTTP calls

Implementation notes

instrument all sub-classes of ClientHttpConnector seems a good start

Issue Analytics

State:
Created 3 years ago
Reactions:14
Comments:17 (9 by maintainers)

Top GitHub Comments

10reactions

msalaslocommented, Apr 25, 2022

Great work. It seems development has been done. Do you have any ETA to merge in the release?

5reactions

SylvainJugecommented, Feb 15, 2021

FYI I am currently working on the #1305 PR, which adds server-side support for Webflux, there is a dependency on reactor instrumentation (that will also be added by this PR), thus there will likely be some overlap if you implement the client-side.

Any help being more than welcome, if you have something that works for you we’ll be happy to review it, please open a draft PR when you can so we can see what is the best way to move this forward. One aspect for which contributions are more than welcome is test suites so we can ensure that implementation will work with your use-cases.