"minimum_should_match" disappears from query in some cases

>>> import elasticsearch_dsl
>>> elasticsearch_dsl.VERSION
(2, 0, 0)
>>> from elasticsearch_dsl import Search, Q

When filter is after query method, ‘minimum_should_match’ exist in query:

>>> s = Search()
>>> s.query(q).filter('term', status=1).to_dict()
{'query': {'bool': {'filter': [{'term': {'status': 1}}],
   'minimum_should_match': 1,
   'should': [{'match': {'name': 'abc'}}]}}}

But if we change order of filter and query, than ‘minimum_should_match’ disappears:

>>> s = Search()
>>> s.filter('term', status=1).query(q).to_dict()
{'query': {'bool': {'filter': [{'term': {'status': 1}}],
   'should': [{'match': {'name': 'abc'}}]}}}

[SamuelRamond]

Hi, we had the same problem and this solved our issue. Can you make a release of this version for pip install ?

Thanks for your work 👍

[honzakral]

Thank you @solarissmoke! This is very useful feedback and helped me discover a bug where doing Bool & NotBool the minimum_should_match was ignored. That’s why the order mattered.

I pushed a fix in 4b4487d0659ac8f2cf0e6499009ce696fca35684 for this particular case with a test.

I will close the issue now, feel free to reopen if the issue isn’t resolved.

Thanks again for all the help!