7.0.0-alpha2 breaking formatter backwards compatibility

ElasticLowLevelClient.Serializer.SerializeToString()

introduced a new IMemoryStreamFactory parameter in the middle of the parameter chain - this means that libraries compiled against ElasticSearch.Net 6.X don’t work with references to 7.0; this includes libraries installed from NuGet. The AssemblyRedirects generated will try to call SerializeToString() with parameters (data, format) instead of (data, null, format) throwing an error.

It’d be nice getting a SerializeToString() implementation without the IMemoryStreamFactory parameter for backwards compatibility so that existing libraries don’t break.

[kanadaj]

@Mpdreamz Happy to help, Elasticsearch really does a lot for us as a free tool (I really want the paid features like alerts and the other machine learning goodies but we simply can’t afford it, it’s too steep 😢 ) so I’m happy to contribute where I can.

Personally, I don’t think netstandard1.3 needs to be carried forward - it’s fairly simple to migrate from Core 1.X to Core 2.2 for any ASP.NET Core app (and let’s be fair, Core 1.X wasn’t really good for much else, and even then it lacked a lot of features, so I imagine almost all web apps are already on 2.X).

[Mpdreamz]

This relates to: https://github.com/serilog/serilog-sinks-elasticsearch/pull/249

@kanadaj we are looking to take a more active involvement in the sink again and are meeting @mivano next week. Thank you for that PR by the way, its something we have on the backlog to do in the coming weeks!

Some special care will need to be taken to ensure the sink works against 6.x Elasticsearch using the 7.x client and the sink will need to be stricter about not allowing major version bumps since these type of breakages will happen on major version changes.

Ideally we update the sinks dependency to 7.0.0 across the board and make sure all the TFM’s are available to so. I am not sure netstandard1.3 needs to be carried forward but it’d be great to get some wider feedback on that.