bulk() and streaming_bulk() helpers don't apply the `ignore` argument to op results
See original GitHub issueThe documentation for ignore
indicates:
An API call is considered successful (and will return a response) if elasticsearch returns a 2XX response. Otherwise an instance of TransportError (or a more specific subclass) will be raised. You can see other exception and error states in Exceptions. If you do not wish an exception to be raised you can always pass in an ignore parameter with either a single status code that should be ignored or a list of them
The bulk()
and streaming_bulk()
helpers parameters accept the ignore
argument and pass it through to the underlying API call, but don’t otherwise consider it while processing results. It would be more useful (and more consistent with how ignore
works with other client methods) to apply the value to individual op results, treating ops with ignored statuses as successful.
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (3 by maintainers)
Top GitHub Comments
@arusahni that is a great idea, thank you! Just not sure about the best naming. But definitely doable and quite simple to do.
Reopening the issue to keep track of this.
@sethmlarson Guess you forgot to close the issue…