create(**kwargs) doesn't work if document id is not provided

Elasticsearch version (bin/elasticsearch --version): 7.6.2

elasticsearch-py version (elasticsearch.__versionstr__): 7.7.1

Please make sure the major version matches the Elasticsearch server you are running.

Description of the problem including expected versus actual behavior: Calling create(**kwargs) without providing a document Id causes an error when it should create a new document with autogenerated Id using POST method (instead of PUT).

Issue in init.py:

    for param in (index, id, body): # id should be removed from here
        if param in SKIP_IN_PATH:
            raise ValueError("Empty value passed for a required argument.")

    if doc_type in SKIP_IN_PATH:
        path = _make_path(index, "_create", id)
    else:
        path = _make_path(index, doc_type, id)

    return self.transport.perform_request(
        "POST" if id in SKIP_IN_PATH else "PUT", # calling "POST" instead of "PUT" is already implemented
        path,
        params=params,
        headers=headers,
        body=body,
    )

Steps to reproduce: Call create method without providing a document Id and it will throw a ValueError

[sethmlarson]

@DuoPegla You’re able to create documents without specifying the id via .index():

from elasticsearch import Elasticsearch
es = Elasticsearch()
resp = es.index("test-index", body={"key": "value"})

print(resp)
{
  "_id": "GjlAYXIBW0qL5IyTJ2x1",  # Auto-generated ID
  "_index": "test-index",
  "_primary_term": 1,
  "_seq_no": 3,
  "_shards": {
    "failed": 0,
    "successful": 1,
    "total": 2
  },
  "_version": 1,
  "result": "created"
}

You can think of create as just for “create a document w/ ID without the option of updating it”. .create() requires an ID to verify that the document doesn’t already exist (will error in this case). .index() when given an ID will either create the document or update it if it already exists. Basically .index() is what you’re looking for here. 😃

[DuoPegla]

Thanks a lot! I must have missed that in the docs, just assumed given the name that create is the one I’m looking for.