Query string missing from url path in log_request_success and log_request_fail
See original GitHub issueElasticsearch version (bin/elasticsearch --version
): 7.4.2
elasticsearch-py
version (elasticsearch.__versionstr__
): 7.13.4
Please make sure the major version matches the Elasticsearch server you are running.
Description of the problem including expected versus actual behavior:
When using AIOHttpConnection, url path is missing query string when being passed to log_request_success
or log_request_fail
Steps to reproduce:
I will submit a PR shortly which includes tests which fail on current version EDIT: https://github.com/elastic/elasticsearch-py/pull/1827
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (3 by maintainers)
Top Results From Across the Web
Why there is a missing parameter in my query string?
I have a url https://something.com/?a=111&b=222&c=333. when I use window.location.href to get the full path c=333 is missing for no reason, ...
Read more >URLSearchParams - Web APIs - MDN Web Docs
Chrome Edge
URLSearchParams Full support. Chrome49. Toggle history Full support. Edge...
@@iterator Full support. Chrome49. Toggle history Full support. Edge...
URLSearchParams() constructor Full support. Chrome49. Toggle...
Read more >Using Query Parameters (AWS Signature Version 4)
Authenticate requests using the query parameters to express a request entirely in a URL.
Read more >Requests - Rocket Programming Guide
Query parameters are allowed to be missing. As long as a request's query string contains all of the static components of a route's...
Read more >query-string - npm
Parse and stringify URL query strings. Latest version: 8.1.0, last published: 17 hours ago. Start using query-string in your project by running `npm...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I didn’t check it myself but I can see that elasticsearch-py is pinned to 7.13.* in our project and this stackoverflow thread is linked in the comment. So I guess it’s the same issue. Our server version is 7.4.2. If I understand the docs correctly, our client version shouldn’t be higher than that, but that still wouldn’t solve our problem.
Closed in https://github.com/elastic/elasticsearch-py/pull/1829