Elasticsearch: Resources created by chart are keyed off of clusterName rather than Release.Name

Chart version: 7.1.0

Kubernetes version: 1.14

Kubernetes provider: Azure

Helm Version: 2.14

Describe the bug: The resources created by the chart are keyed off of the clusterName value, rather than Release.Name.

This doesn’t follow normal Helm patterns, meaning that if you run helm install elastic/elasticsearch twice (with different release names but not specifying a clusterName), the second deployment will fail, as well as break the first one.

Steps to reproduce:

1. helm install --name dude-elasticsearch elastic/elasticsearch
2. Wait for cluster to come up.
3. helm install --name sweet-elasticsearch elastic/elasticsearch
4. Observe brokenness of dude-elasticsearch, and failure of deployment of sweet-elasticsearch.

Expected behavior: It should be possible to run the chart twice without having to specify a clusterName and end up with two working Elasticsearch clusters within k8s.

[jmlrt]

Hi @desaintmartin, As mentionned in https://github.com/elastic/helm-charts/issues/150#issuecomment-499513145, despite there is good reasons for changing it, this is not something we will change before next major release (8.0.0), so yes the current naming is the way to go for now.

[desaintmartin]

In fact, this would prevent deployment of two different ES Helm Releases in the same namespace if the clustername is the same. Could we have a hybrid approach where name is generated from both .Release.Name and cluster name (with maybe some intelligence to prevent duplication)?