Recursion in `asar. createPackageFromFiles` won't handle very large file lists
See original GitHub issueIntroducted in #73.
asar.createPackageFromFiles now uses recursion to handle the list of files which is ok for a reasonable number of files but over in GitKraken we have an unreasonable number of files we’re putting into the asar (~100k) which causes a Maximum call stack size exceeded
.
As unreasonably large as the that number is, when using node/npm for a large project that no longer really becomes an edge case.
Issue Analytics
- State:
- Created 7 years ago
- Reactions:5
- Comments:5 (2 by maintainers)
Top Results From Across the Web
c# - Optimizing a Recursive Function for Very Large Lists .Net
The PC that runs this application is on the old side and cannot handle the number of calculations before an out of memory...
Read more >Recursion in Python: An Introduction - Real Python
You can set it to be pretty large, but you can't make it infinite. There isn't much use for a function to indiscriminately...
Read more >11. Recursion and exceptions - Computer Science
One of the differences we noted is that the elements of a list can be modified, but the characters in a string cannot....
Read more >Python | Handling recursion limit - GeeksforGeeks
When you execute a recursive function in Python on a large input ( > 10^4), you might encounter a “maximum recursion depth exceeded...
Read more >Recursive File List VI - NI - National Instruments
Note This VI does not support shortcuts and symbolic links to folders or LLB files. Specify a path to the target folder or...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@develar I submitted a PR with a fix. I tested with 104k files and it worked.
@gerhardberger Please fix it ASAP. https://github.com/electron-userland/electron-builder/issues/606