windows build appears broken

Hard to say if it’s the same underlying issue but https://github.com/electron/build-tools/issues/261 is still broken for me.

I’m using the following docker config (note I don’t think this has anything to do with docker…it’s just what i’m using):

FROM mcr.microsoft.com/windows:2004

ENV chocolateyUseWindowsCompression false

RUN powershell -Command Set-ExecutionPolicy Unrestricted -Force
RUN powershell -Command \
    iex ((new-object net.webclient).DownloadString('https://chocolatey.org/install.ps1')); \
    choco feature disable --name showDownloadProgress

RUN choco install -y -d --accept-license git
RUN git config --system core.longpaths true

RUN choco install -y -d --accept-license nodejs
RUN choco install -y -d --accept-license vim

# chrome build needs python2...eww
RUN choco install -y -d --accept-license python2
RUN pip install pywin32
RUN pip install crcmod

# https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md#visual-studio
RUN choco install -y -d --accept-license visualstudio2019community \
    --package-parameters \
    "--add Microsoft.VisualStudio.Workload.NativeDesktop --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended --passive"

# https://github.com/electron/build-tools
RUN npm install --global yarn
RUN npm i -g @electron/build-tools

# Setup required git settings for electron build tools
# If you don't set these the e init will fail
RUN git config --global core.filemode false
RUN git config --global core.autocrlf false
RUN git config --global branch.autosetuprebase always

RUN e init --root=C:/electron release
RUN e sync -vvvv

CMD [ "cmd" ]

FYI I need to increase the default vm size because 20GB isn’t enough. I did this through editing "C:\ProgramData\Docker\config\daemon.json" to:

{
  "registry-mirrors": [],
  "insecure-registries": [],
  "debug": false,
  "experimental": false,
  "storage-opts": [
    "size=60GB"
  ]
}

and restarting docker.

Then you have to build with a larger memory because the default isn’t enough. docker build --memory 8g electron_builid_win .

After that, run the container: docker run --memory 8g -it electron_builder_win

And try to build: e build electron:dist

and get:

Writing new goma.gn file C:\Users\ContainerAdministrator\.electron_build_tools\third_party\goma.gn
Downloading "https://electron-build-tools.s3-us-west-2.amazonaws.com/build-dependencies/064e0beb3c11b82b66ae4b4959e6c0cdaa2116d77c50841e4a213d4f4fb1aeaf/goma-win.zip" into C:\Users\ContainerAdministrator\.electron_build_tools\third_party\goma-win.zip
[=======================================================================================================================================================================================================] 9266800/bps 100% 0.0s 
Running "goma_ctl.py ensure_start" in C:\Users\ContainerAdministrator\.electron_build_tools\third_party\goma
ERROR Error: Command failed: C:\Windows\system32\cmd.exe /d /s /c "vpython goma_ctl.py ensure_start"
'vpython' is not recognized as an internal or external command,
operable program or batch file.

    at checkExecSyncError (node:child_process:690:11)
    at Object.execFileSync (node:child_process:709:15)
    at Object.ensureGomaStart [as ensure] (C:\Users\ContainerAdministrator\.electron_build_tools\src\utils\goma.js:175:16)
    at runNinja (C:\Users\ContainerAdministrator\.electron_build_tools\src\e-build.js:60:10)
    at Object.<anonymous> (C:\Users\ContainerAdministrator\.electron_build_tools\src\e-build.js:133:3)
    at Module._compile (node:internal/modules/cjs/loader:1092:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1121:10)
    at Module.load (node:internal/modules/cjs/loader:972:32)
    at Function.Module._load (node:internal/modules/cjs/loader:813:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)

[rconde01]

ok - that workaround get’s me past that problem…then in the build I hit: ../../buildtools/third_party/libc++/trunk/include\__config(297,14): fatal error: 'winapifamily.h' file not found and #include <windows.h>

winapifamily.h is definitely in multiple places.

[rconde01]

I’m not using goma I don’t think. I did:

cd C:\Users\user\.electron_build_tools\third_party\goma
goma_ctl.bat ensure_start
e build electron:dist

At this point i’m a bit more interested in having e build electron:dist properly then just working around the problem. Unless investigating the workaround helps narrow down the required fix.