Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Cannot unzip on Windows if user directory contains whitespace

See original GitHub issue

Preflight Checklist

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project follows, as appropriate.
I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Packager Version:
- 14.2.1
Electron Version:
- v8.0.0
Operating System:
- Windows 10 (1903)
Last Known Working Electron Packager version::
- unknown

Expected Behavior

electron-packager should work

Actual Behavior

electron-packager terminates with

[Error: ENOENT: no such file or directory, rename 'C:\Users\JANNIS~1\AppData\Local\Temp\electron-packager\win32-x64\VIPFY-win32-x64\electron.exe' -> 'C:\Users\JANNIS~1\AppData\Local\Temp\electron-packager\win32-x64\VIPFY-win32-x64\VIPFY.exe'] {      
  errno: -4058,
  code: 'ENOENT',
  syscall: 'rename',
  path: 'C:\\Users\\JANNIS~1\\AppData\\Local\\Temp\\electron-packager\\win32-x64\\VIPFY-win32-x64\\electron.exe',
  dest: 'C:\\Users\\JANNIS~1\\AppData\\Local\\Temp\\electron-packager\\win32-x64\\VIPFY-win32-x64\\VIPFY.exe'
}

To Reproduce

Use a user directory with whitespace, or alternatively set APPDATALOCAL environment variable to a directory with whitespace

For example in Powershell:

$env:LOCALAPPDATA = "C:\test\folder with whitespace\"
# ensure this folder exists
electron-packager . #or any electron-packager call that normally works

Additional Information

Relevant console output:

electron-packager Creating C:\Users\JANNIS~1\AppData\Local\Temp\electron-packager\win32-x64-template +16ms
  electron-packager Extracting C:\Users\Jannis Froese\AppData\Local\electron\Cache\httpsgithub.comelectronelectronreleasesdownloadv8.0.0-beta.4electron-v8.0.0-beta.4-win32-x64.zip\electron-v8.0.0-beta.4-win32-x64.zip to C:\Users\JANNIS~1\AppData\Local\Temp\electron-packager\win32-x64-template +2ms
  electron-packager Ignored paths based on the out param: [ 'C:\\Users\\Jannis Froese\\Source\\vipfy-desktop\\out' ] +0ms

Error: ENOENT: no such file or directory, rename 'C:\Users\JANNIS~1\AppData\Local\Temp\electron-packager\win32-x64\VIPFY-win32-x64\electron.exe' -> 'C:\Users\JANNIS~1\AppData\Local\Temp\electron-packager\win32-x64\VIPFY-win32-x64\VIPFY.exe'] {      
  errno: -4058,
  code: 'ENOENT',
  syscall: 'rename',
  path: 'C:\\Users\\JANNIS~1\\AppData\\Local\\Temp\\electron-packager\\win32-x64\\VIPFY-win32-x64\\electron.exe',
  dest: 'C:\\Users\\JANNIS~1\\AppData\\Local\\Temp\\electron-packager\\win32-x64\\VIPFY-win32-x64\\VIPFY.exe'
}

Manually running cross-zip-cli with the exact paths as shown in the debug output extracts the zip file correctly