Setting icon for Mac still shows default icon

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

I followed https://blog.macsales.com/28492-create-your-own-custom-icons-in-10-7-5-or-later

Then I ran

Console output when you run electron-packager with the environment variable DEBUG=electron-packager. Please include the stack trace if one exists.

~/Desktop/out/electron-packager ~/code/electron-quick-start/ QuantumPilot --platform=all --icon=../QuantumPilot.iconset/
Packaging app for platform darwin x64 using electron v0.36.11
Packaging app for platform linux x64 using electron v0.36.11
Packaging app for platform mas x64 using electron v0.36.11
WARNING: signing is required for mas builds. Provide the osx-sign option, or manually sign the app later.
Packaging app for platform win32 x64 using electron v0.36.11
Wrote new apps to:
/Users/quantum/Desktop/out/QuantumPilot-darwin-x64
/Users/quantum/Desktop/out/QuantumPilot-linux-x64
/Users/quantum/Desktop/out/QuantumPilot-mas-x64
/Users/quantum/Desktop/out/QuantumPilot-win32-x64
<!-- For bugs and questions, please answer these questions to the best of your ability. -->

What command line arguments are you passing? Alternatively, if you are using the API, what parameters are you passing to the packager() function?

--icon="../QuantumPilot.iconset/"

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to reproduce your problem. Using electron-quick-start is a good starting point.

The app icon still shows the default. How do I make custom icons?

[JohannBlake]

The default icon still shows when I launch the app during development. I’m not using a package installer at this stage. I’m just running npm start from the command line. Changing the app icon use to work but this morning I upgraded Electron to the latest version (1.7.9) and the default always shows. I’m running this on a Mac.

I simply replaced the electron.icns file with my custom icon. This file is located under:

/usr/local/lib/node_modules/electron/dist/Electron.app/Contents/Resources/electron.icns

Restarting the app or my computer didn’t help either. Interestingly, if I click on:

/usr/local/lib/node_modules/electron/dist/Electron.app

the icon shows in Finder’s preview pane although the default icon is showing in the left pane next to the app’s executable. My custom icon also shows if you bring up the Info pane for the app.

UPDATE:

I was able to solve this. When I converted my png file to icns, my png was 512 x 512. I then increased the size to 1024 x 1024 and then converted it to icns. It appears that something changed in electron since my previous version of electron that now requires a higher resolution image.

[MarshallOfSound]

http://stackoverflow.com/questions/12306223/how-to-manually-create-icns-files-using-iconutil