question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Close (X) button in Settings not focusable at all

See original GitHub issue

When you go to any page in the Settings, there is an X that appears in the upper righthand corner. You can click that to exit this view, but it’s not focusable at all when navigating with a keyboard.

Screenshot of the top of the Executions page. In the corner you can see a white X.

This is likely because the X, semantically speaking, is not a button when it likely should be 😬

From settings.tsx:

<div className="settings-close" onClick={appState.toggleSettings}>
    <Icon icon="cross" iconSize={25} />
</div>

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
VerteDindecommented, May 27, 2022

Hey @Hanaffi! Please feel free to just submit a PR for this if you’d like to work on it.

0reactions
Hanafficommented, May 29, 2022

Okk , It was WSL2 issue. handled it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Make an HTML element non-focusable - Stack Overflow
In order to prevent an element from being tabbed to, use tabindex=-1 attribute. Adding tabindex=-1 will make any element focusable, even div ...
Read more >
How do I keep the X showing to close non-active tabs with one ...
I'm currently using Firefox Quantum 64.0.2. Basically, I'd like the X that lets me close a tab with just a click to stay...
Read more >
'X (Close)' button is not focusable - Screencast-O-Matic
' X ( Close )' button is not focusable.
Read more >
Control focus with tabindex - web.dev
Try pressing the Tab key to navigate through your site. Are you able to reach all the interactive controls on the page? If...
Read more >
Use Do Not Disturb with Focus on your iPhone or iPad
Go to Settings > Focus. · Tap Do Not Disturb. iPhone screen showing how to turn on Do not Disturb · Under Turn...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found