question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Infrastructure: Replace electron-download, improve download experience

See original GitHub issue

We’re currently using electron-download. This has benefits: We’re now that we’re always downloading the “right” Electron binary and can simply pull in its latest version to get the same behavior as npm i electron.

But it also has downsides:

  • electron-download constantly prints to stdout, creating quite a bit of unnecessary work when used as a library
  • It comes with dependencies that need resources but end up not benefiting the user experience
  • We currently can’t get the progress of the download

We should either improve electron-download to the point where it can be properly used as a library or replace it entirely. Improving is probably the better path but it might require splitting electron-download into multiple packages.

cc @MarshallOfSound

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
maleptcommented, Feb 21, 2020

As well, allow the download to be cancelled by hovering and clicking on the same area.

I’ll need to think about how we can expose download cancellation so we can resolve #320. It seems problematic with the current implementation because we’re using stream piping to write the HTTP response to a file.

1reaction
erickzhaocommented, Feb 21, 2020

@malept Would probably be ideal to show progress using a Blueprint.js component in the Version Select right where the “Downloading” text is right now. As well, allow the download to be cancelled by hovering and clicking on the same area.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Download always interrupted when downloading from ...
I have a desktop app I'm building with electron. The UI hits a flask server I have running on local host and tries...
Read more >
Using Electron with Yarn PnP - Electric UI
Hosting these files on our infrastructure guaranteed a consistent download experience. Our problem with node_modules. A brief, simplified refresher of the ...
Read more >
8 Simple and Effective Ways to Increase Download Speed
Is your internet so slow you can't game, download, or even browse the web? Follow this guide to increase your download speed.
Read more >
How To Increase Download Speed: 19 Tricks To SPEED UP ...
In this tutorial, we will learn How To Increase Download Speed and explore various solutions to speed up the Internet on Windows 10....
Read more >
15 Ways to Increase Your Internet Speed Today
D o you want to learn how to increase your download speed? ... We recommend replacing your modem every 3-4 years or so...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found