DevDependencies are not removed when packaging app

Pre-flight checklist

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project uses.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.0-beta.67

Electron version

21.0.1

Operating system

macOS Monterey 12.4

Last known working Electron Forge version

No response

Expected behavior

Expected all devDependencies in package.json to be pruned prior to generating the output from electron-forge make or electron-forge package

Actual behavior

When running electron-forge package on my app, I noticed that the packaged app size is quite large, and none of the devDependencies are pruned.

For example, here’s a list of some of my devDependencies:

    "eslint-config-prettier": "^8.5.0",
    "eslint-import-resolver-typescript": "^3.5.2",
    "eslint-plugin-import": "^2.26.0",
    "eslint-plugin-prettier": "^4.2.1",
    "eslint-plugin-react": "^7.31.10",
    "eslint-plugin-react-hooks": "^4.6.0",

After packaging my app, I can see all of these in the out/my_app/.../node_modules folder:

Steps to reproduce

1. Create an Electron app
2. Install some devDependencies (like eslint)
3. Run electron-forge make

Additional information

Forge config:

  "config": {
    "forge": {
      "packagerConfig": {
        "icon": "./assets/icon",
        "ignore": [
          "src",
          "assets",
          "webpack",
          "public",
          "tsconfig.json",
          ".eslintrc.js",
          ".prettierrc.js",
          "postcss.config.js",
          "prettier.config.js",
          "tailwind.config.js",
          "README.md",
          "LICENSE.md",
          "__previewjs__"
        ]
      },
      "makers": [
        {
          "name": "@electron-forge/maker-squirrel",
          "config": {
            "name": "my_app"
          }
        },
        {
          "name": "@electron-forge/maker-zip",
          "platforms": [
            "darwin"
          ]
        },
        {
          "name": "@electron-forge/maker-deb",
          "config": {}
        },
        {
          "name": "@electron-forge/maker-rpm",
          "config": {}
        }
      ]
    }
  }

[jordanarldt]

@erikian Ahhh excellent callout. After my last comment I actually was wondering if all of these came from react being in my project. I will do more research and testing to see if I can make sure my app works properly while react-scripts is in the devDependencies. If not, I guess it’s not a huge deal. Just trying to keep my project as lightweight as possible!

[erickzhao]

Seems like this is resolved. Closing!