exe file not updated with given icon
See original GitHub issueHi,
When building using electron-forge
, the Windows application exe icon is not changed.
Command used to make: ./node_modules/.bin/electron-forge.cmd make
config.forge.electronPackagerConfig in package.json:
"electronPackagerConfig": {
"icon": "./assets/img/icon.ico",
"electronVersion": "1.4.4",
"asar": true
},
"electronWinstallerConfig": {
"name": "eapp",
"setupExe": "eapp-0.0.2.exe",
"description": "EApp Application",
"loadingGif": "./assets/img/install-splash-anim.gif",
"iconUrl": "http://manikanta.com/favicon.ico",
"setupIcon": "./assets/img/icon.ico",
"noMsi": true
}
Note: Setup exe is getting generated with correct icon, mentioned in config.forge.electronWinstallerConfig
But if I run the electron-packager
manually, icon is changed:
.\node_modules\.bin\electron-packager ./ --asar=true --icon=./assets/img/icon.ico --electron-version=1.4.4
Even some other config params of electron-packager
are not being picked up from package.json as described in electron-packager api. For example, even though I’ve specified author
in package.json, I’ve to specify that in config.forge.electronPackagerConfig.win32metadata
.
Stack: Windows 8.1 x64, electron-forge: 2.6.0, electron-prebuilt-compile: 1.4.4
Is this a bug with electron-forge
? or, am I missing something? Thanks.
Issue Analytics
- State:
- Created 7 years ago
- Comments:18 (8 by maintainers)
Top GitHub Comments
solution: ie4uinit -show
It may be updated. Windows cache all icons. So try this:
ie4uinit -show
in cmd. It’ll revalidate all cached icons.@dephraiim this kind of comment isn’t particularly actionable. The best kind of comment has a minimal testcase ready for someone to clone a git repo and run.
I can successfully set all three icon config options for Windows/Squirrel: