Packaging succeeds despite Webpack compilation errors

• [ x] I have read the contribution documentation for this project.
• [x ] I agree to follow the code of conduct that this project follows, as appropriate.
• [x ] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

If Webpack compilation has errors (e.g. due to typescript compilation), both electron-forge start and electron-forge package scripts succeed without any warnings.

In case of electron-forge package, no files are emitted as noEmitOnErrors plugin is set up. The command should fail and display the errors.

For electron-forge start, files are emitted as they should be, but the webpack compilation errors should be displayed.

Here’s a repo with the setup: https://github.com/tgds/electrong-forge-webpack-typescript

[MarshallOfSound]

@tgds This was opened yesterday --> https://github.com/electron-userland/electron-forge/issues/703

I hacked a bit on it last night, it’s a tough one to solve, I think I’m on a track to a generic enough hack though that might work 😆

It’s tough to solve without externals (and I really want to avoid using externals as it defeats the purpose of bundling all JS)

[jrobeson]

The webpack plugin can start and fail, leaving you with this

Webpack Output Available: http://localhost:9000

Error launching app
Unable to find Electron app at /path/to/app

Cannot find module '/path/to/app'

and by the time you get there, the http server has already closed itself out, so you don’t even know if you’re say… missing ts-loader. I couldn’t get my app to start, because I didn’t know enough about webpack to know I needed it. I had to use @tgds’s example repo to find out.

NOTE: I’m only using webpack at all because electron-compile seems unmaintained.