start does not work with yarn workspaces

Preflight Checklist

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

• Electron Forge Version:
  • 6.0.0-beta.47
• Electron Version:
  • v7.1.7
• Operating System:
  • macOS 10.14.6 (18G95)
• Last Known Working Electron Forge version::
  • none

Expected Behavior

No error

Actual Behavior

To Reproduce

• This is the error repository: https://github.com/kamontat/KingKnight/tree/issues/yarn-workspace
• In order to run the project:
  • run yarn install:all
  • run yarn compile
  • run yarn start

Additional Information

Error log:

@kk/app: $ electron-forge start
@kk/app: WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
@kk/app: 2019-12-31T19:33:52.010Z electron-forge:async-ora Process Started: Checking your system
@kk/app: 2019-12-31T19:33:52.011Z electron-forge:check-system checking system, create ~/.skip-forge-system-check to stop doing this
@kk/app: 2019-12-31T19:33:52.269Z electron-forge:async-ora Process Succeeded: Checking your system -- after 259ms
@kk/app: WARNING: DEBUG environment variable detected.  Progress indicators will be sent over electron-forge:lifecycle
@kk/app: 2019-12-31T19:33:52.601Z electron-forge:async-ora Process Started: Locating Application
@kk/app: 2019-12-31T19:33:52.602Z electron-forge:project-resolver searching for project in: /Users/kchantrachir/Desktop/Personal/KingKnight/packages/app
@kk/app: 2019-12-31T19:33:52.603Z electron-forge:project-resolver electron-forge compatible package.json found in /Users/kchantrachir/Desktop/Personal/KingKnight/packages/app/package.json
@kk/app: 2019-12-31T19:33:52.603Z electron-forge:async-ora Process Succeeded: Locating Application -- after 2ms
@kk/app: 2019-12-31T19:33:52.606Z electron-forge:require-search searching [
@kk/app:   '@electron-forge/plugin-webpack',
@kk/app:   '/Users/kchantrachir/Desktop/Personal/KingKnight/packages/app/@electron-forge/plugin-webpack',
@kk/app:   '/Users/kchantrachir/Desktop/Personal/KingKnight/packages/app/node_modules/@electron-forge/plugin-webpack'
@kk/app: ] relative to /Users/kchantrachir/Desktop/Personal/KingKnight/packages/app
@kk/app: 2019-12-31T19:33:52.607Z electron-forge:require-search testing @electron-forge/plugin-webpack
@kk/app: 2019-12-31T19:33:52.848Z electron-forge:plugin:webpack hooking process events
@kk/app: 2019-12-31T19:33:52.850Z electron-forge:async-ora Process Started: Preparing native dependencies
@kk/app: 2019-12-31T19:33:52.856Z electron-forge:async-ora Process Succeeded: Preparing native dependencies -- after 6ms
@kk/app: 2019-12-31T19:33:52.856Z electron-forge:plugins plugin: "webpack" has taken control of the start command
@kk/app: 2019-12-31T19:33:52.861Z electron-forge:async-ora Process Started: Compiling Main Process Code
@kk/app: Starting type checking service...
@kk/app: Using 1 worker with 2048MB memory limit
@kk/app: 2019-12-31T19:33:56.618Z electron-forge:async-ora Process Succeeded: Compiling Main Process Code -- after 3.8s
@kk/app: 2019-12-31T19:33:56.618Z electron-forge:async-ora Process Started: Launch Dev Servers
@kk/app: 2019-12-31T19:33:56.635Z electron-forge:async-ora Process Succeeded: Launch Dev Servers -- after 17ms
@kk/app: 2019-12-31T19:33:56.635Z electron-forge:async-ora Process Started: Compiling Preload Scripts
@kk/app: 2019-12-31T19:33:56.635Z electron-forge:async-ora Process Succeeded: Compiling Preload Scripts -- after 0ms
@kk/app:
@kk/app: An unhandled rejection has occurred inside Forge:
@kk/app: Error: Cannot find module '/Users/kchantrachir/Desktop/Personal/KingKnight/packages/app/node_modules/electron'
@kk/app: Require stack:
@kk/app: - /Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/core/dist/api/start.js
@kk/app: - /Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/core/dist/api/index.js
@kk/app: - /Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/cli/dist/electron-forge-start.js
@kk/app:     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:797:15)
@kk/app:     at Function.Module._load (internal/modules/cjs/loader.js:690:27)
@kk/app:     at Module.require (internal/modules/cjs/loader.js:852:19)
@kk/app:     at require (internal/modules/cjs/helpers.js:74:18)
@kk/app:     at forgeSpawn (/Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/core/src/api/start.ts:81:26)
@kk/app:     at processTicksAndRejections (internal/process/task_queues.js:93:5)
@kk/app:     at forgeSpawnWrapper (/Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/core/src/api/start.ts:121:21)
@kk/app:     at /Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/cli/src/electron-forge-start.ts:59:19 {
@kk/app:   code: 'MODULE_NOT_FOUND',
@kk/app:   requireStack: [
@kk/app:     '/Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/core/dist/api/start.js',
@kk/app:     '/Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/core/dist/api/index.js',
@kk/app:     '/Users/kchantrachir/Desktop/Personal/KingKnight/node_modules/@electron-forge/cli/dist/electron-forge-start.js'
@kk/app:   ]
@kk/app: }
@kk/app:
@kk/app: Electron Forge was terminated. Location:
@kk/app: {}
@kk/app: 2019-12-31T19:33:56.644Z electron-forge:plugin:webpack handling process exit with: { cleanup: true }
@kk/app: 2019-12-31T19:33:56.644Z electron-forge:plugin:webpack cleaning webpack watcher
@kk/app: 2019-12-31T19:33:56.645Z electron-forge:plugin:webpack cleaning http server
@kk/app: 2019-12-31T19:33:56.645Z electron-forge:plugin:webpack stopping logger

This is a code that might relate to this issue

https://github.com/electron-userland/electron-forge/blob/9b8a2a6acbccf280472b0a378451d6520322a542/packages/api/core/src/api/start.ts#L81

[Bosch-Eli-Black]

@easternmotors Indeed! 🙂

No, I’ve never been able to get electron to work with PnP. The only update to our .yarnrc.yml file since last time I posted is that this section is no longer needed:

# We're using Yarn workspaces, which means that by default, all of our modules are hoisted into a node_modules folder that's in the root folder.
# This breaks electron, so we force each folder (app/, web/, and src/) to have their own node_modules folders.
# https://github.com/electron-userland/electron-forge/issues/869
nmHoistingLimits: workspaces

[easternmotors]

@Bosch-Eli-Black it’s nice to see someone else having similar architecture 😃 by chance have you been able to get it working with PnP (removing nodeLinker from your .yarnrc.yml)? I haven’t 😕