[v6] doesn't work with Webpack 5's DefinePlugin

Preflight Checklist

• I have read the contribution documentation for this project.
• I agree to follow the code of conduct that this project follows, as appropriate.
• I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

• Electron Forge Version:
  • 6.0.0-beta.54
• Electron Version:
  • v11.3.0
• Operating System:
  • Windows 10
• Last Known Working Electron Forge version::
  • N/A

To Reproduce

I’m using electron-forge v6 with webpack v5.10.2. It looks like v6 doesn’t like webpack 5’s webpack.DefinePlugin.

My webpack.renderer.config.js looks like this:

module.exports = {
   ...,
   plugins: [
      new webpack.DefinePlugin({
         GLOBALS: JSON.stringify({
            BACKEND_URL: 'http://example.com'
         })
      }
   ]
}

I then use GLOBALS.BACKEND_URL in one of my .js files:

console.log(GLOBALS.BACKEND);

And then when I run yarn electron-forge start, I get this error:

ERROR in ./src/js/components/my_app-ajax.js
Module parse failed: parser.isAsiPosition is not a function
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
TypeError: parser.isAsiPosition is not a function
    at my_app\node_modules\webpack\lib\DefinePlugin.js:308:17
    at SyncBailHook.eval (eval at create (my_app\node_modules\tapable\lib\HookCodeFactory.js:19:10), <anonymous>:5:16)
    at SyncBailHook.lazyCompileHook (my_app\node_modules\tapable\lib\Hook.js:154:20)
    at Parser.walkIdentifier (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1986:25)
    at Parser.walkExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1604:10)
    at Parser.walkMemberExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1969:8)
    at Parser.walkExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1610:10)
    at Parser.walkObjectExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1678:9)
    at Parser.walkExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1616:10)
    at Parser.walkExpressions (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1569:10)
    at Parser.walkCallExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1949:35)
    at Parser.walkExpression (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1592:10)
    at Parser.walkVariableDeclaration (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1469:32)
    at Parser.walkStatement (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:997:10)
    at Parser.walkExportNamedDeclaration (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:1349:9)
    at Parser.walkStatement (my_app\node_modules\@electron-forge\plugin-webpack\node_modules\webpack\lib\Parser.js:961:10)

Additional Information

[Bosch-Eli-Black]

Ah, looks like there’s already a PR open for this: https://github.com/electron-userland/electron-forge/pull/2164

[Bosch-Eli-Black]

@Deliaz We’re using it that way 🙂

var myConfig = {
   test: 'testing'
};

module.exports = {
   .....,
   plugins: [
	new DefinePlugin({
		GLOBALS: JSON.stringify(myConfig)
	}),
   ]
}

I vaguely seem to remember that maybe DefinePlugin only accepts stringified objects, but it looks like you’re passing strings to JSON.stringify(), which could be the problem 🙂