Compiled apps use development version of react and react-dom

Prerequisites

• Using yarn
• Using node 10.x
• Using an up-to-date master branch
• Using latest version of devtools. See wiki for howto update
• Link to stacktrace in a Gist (for bugs)
• For issue in production release, devtools output of DEBUG_PROD=true yarn build && yarn start
• Tried solutions mentioned in #400

Expected Behavior

An app created with yarn package will use react.production.min.js and react-dom.production.min.js

Current Behavior

An app created with yarn package, in vanilla git clone’s of both the master and the next branch, ships with react.development.js and react-dom.development.js, see screenshot below.

Possible Solution

Not found any yet, but I assume NODE_ENV gets overwritten or unset somewhere.

Steps to Reproduce (for bugs)

1. fresh checkout of the repo
2. yarn
3. yarn run package
4. inspect the sources of the app

Context

A compiled app should be as fast as possible, running the production version of react is very important in that context.

Your Environment

• Node version : 10
• Version or Branch used : master as well as next
• Operating System and version : mac os mojave

[Kilian]

yarn start runs electron with NODE_ENV=production prefixed, which is why that does work (though there is a comment there on lacking dead code elimination?)

Thanks for the plugin above! It’s not ideal but it gets the job done! 👍

[barretron]

I can reproduce it using @Kilian 's test after running yarn package (I was using yarn start before, which doesn’t package the app).

Here’s what seems to work for me so far:

Add the following snippet to plugins in the prod webpack configs:

• configs/webpack.config.main.prod.babel.js
• configs/webpack.config.renderer.prod.babel.js

    /**
     * Set NODE_ENV to "production" for external dependencies
     *
     * Note: this is required for both main and renderer
     * separately since the renderer process doesn't inherit
     * the main process's environment on Linux.
     */
    new webpack.BannerPlugin({
      banner: 'process.env.NODE_ENV="production";',
      raw: true,
      entryOnly: true,
      test: /\.js$/
    })

🤷‍♂️ kind of hacky but guarantees that the environment will be set prior to any require statements running