always verbose output.

After upgrading to #400 our build outputs are always verbose now. we use the node api like this.

import rebuild from 'electron-rebuild';

rebuild({
  ...
})

I tried few things but can’t suppress the node-gyp output. I tried setting the log-level to silent through npm env vars, it helps a little but still bunch of logs are printed out.

Any way to make rebuilds quiet? I made sure process.env.DEBUG is not set.

[malept]

this line uses --quiet but it needs to be --silent

Thanks, I’ve fixed that in #837.

yes, this is happening because of node-gyp here node gyp sets the stdio for the childProcess to be inherit=[0, 1, 2] on silent. if I set this to ['ignore', 'ignore', 'ignore'] all output is suppressed. not sure how to approach this as a fix.

This sounds like something that needs to be fixed in node-gyp.

[mmaietta]

I created this patch for electron-rebuild’s output (options available: verbose, silent, warn, silly) electron-rebuild+2.3.5.patch

diff --git a/node_modules/electron-rebuild/lib/src/module-rebuilder.js b/node_modules/electron-rebuild/lib/src/module-rebuilder.js
index 73ddba1..5f3f7c3 100644
--- a/node_modules/electron-rebuild/lib/src/module-rebuilder.js
+++ b/node_modules/electron-rebuild/lib/src/module-rebuilder.js
@@ -70,9 +70,7 @@ class ModuleRebuilder {
             `--dist-url=${this.rebuilder.headerURL}`,
             '--build-from-source'
         ];
-        if (process.env.DEBUG) {
-            args.push('--verbose');
-        }
+        args.push(`--loglevel=${debug.enabled('electron-rebuild') ? 'verbose' : 'silent'}`)
         if (this.rebuilder.debug) {
             args.push('--debug');
         }

The downside is that we can’t filter the verbosity of make, which is what I’m understanding to be the main culprit here. Ref: https://github.com/nodejs/node-gyp/issues/532