Ability to skip uninstallOldVersion macro (NSIS)
See original GitHub issue- Version: 20.2.0
- Target: win32, win64
Currently I’m working in an application that uses a custom autoupdater inside the app. It’s a game launcher, so, sometimes you might want to download a newer version of the launcher but keep your old files as well (as the game is downloaded in the same folder).
The issue is that every new installation erases the entire destination folder prior to installing. I’d like to have an option to just replace without clearing everything up beforehand, so, the uninstallOldVersion should be toggleable.
I tried to remove the macros in installer.nsi and installSection.nsh but electron-builder just throws a warning treated as an error, so I can’t do this without setting warningsAsErrors
as false. However, this requires me to remove lines 49-52 from installSection.nsh, and I have to do this everytime I recreate the node_modules folder.
Any help would be greatly appreciated.
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:9 (5 by maintainers)
Top GitHub Comments
It is is strictly forbidden and not allowed. Not recommended — please do not modify app installation dir, instead, write data to user data dir.
@darkguy2008 Is is common practice to not write into app dir. Issue is closed — but it doesn’t mean that your PR will be rejected. I have limited free time and “issue closed” means “I don’t have time to implement this rare case”. As you can see, label “won’t fix” is not added and conversation is not locked (you can comment).