Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

asar smart unpack unpacks the whole lzma-native module

See original GitHub issue

Version: 19.4.0

Target: dmg

From https://github.com/electron-userland/electron-builder/issues/1723.

Enabling smartUnpack causes the whole lzma-native module to be unpacked for some reason.

$ ls dist/mac/Etcher.app/Contents/Resources/app.asar.unpacked/node_modules
lzma-native/
$ ls dist/mac/Etcher.app/Contents/Resources/app.asar.unpacked/node_modules/lzma-native
LICENSE            binding/           build/             deps/              liblzma-build.sh*  node_modules/      src/
bin/               binding.gyp        cflags.sh*         index.js           liblzma-config.sh* package.json

Try to build Etcher (https://github.com/resin-io/etcher) for an example.

Issue Analytics

State:
Created 6 years ago
Comments:7 (7 by maintainers)

Top GitHub Comments

1reaction

develarcommented, Jun 23, 2017

when you publish this to npm.

19.8.0 released.

0reactions

jviotticommented, Jun 23, 2017

Awesome, thanks a lot for the quick fix. Please let me know when you publish this to npm.

BTW – highly recommended to use yarn and yarn clean (but do not rely on default yarn clean file, please use only https://github.com/develar/onshape-desktop-shell/blob/master/.yarnclean, because *.yml rule must be removed (yml files requited for NSIS).

Yeah, we’ve been wanting to move to Yarn for a while, but there are some issues with optional dependencies that prevented us from adopting it. There were some yarn tickets we were tracking for this, so maybe a good time to give it another go.