Autoupdate downloads new update, but does not successfully update the app on quit.

(This is a follow up on https://github.com/electron-userland/electron-builder/issues/2006#issuecomment-346104571)

Unfortunately I am still seeing this issue with electron-builder 19.45.5 and electron 1.7.9.

I’m not sure if the underlying cause is the same, but on the surface, here’s what happens:

1. Open Mac app, receive update-downloaded event.
2. Instruct user to quit app and re-open to install update.
3. User quits app, and re-opens immediately.

Result:

• App is not upgraded. update-downloaded is received again. Repeat steps 1-3, same results.

After repeating many times, it will eventually update.

Any ideas as what could be causing this? Does user have to wait X seconds after quitting app before re-opening?

My index.js: https://github.com/standardnotes/desktop/blob/master/app/index.js#L29

You can test this issue for yourself by downloading an older version of Standard Notes and waiting for the update message to appear in the lower right corner of the app: https://github.com/standardnotes/desktop/releases

[MarkusBansky]

Got exactly the same issue. Not sure about several updates, but my app is not updating itself after successfully downloading from server and restarting on quitAndInstall()

[dsabanin]

I noticed in my case that after running quitAndInstall(), the app quits and ShipIt process starts in the background that actually copies the update file. Depending on the size of your app, some of them can be pretty big, and it can take at least 30 seconds to finish. If you try running app right away before that process is over, you get the old version, if you run after ShipIt is done, you’ll get the new version. I’m not sure how it’s supposed to work 🤷‍♂️

Edit: I’m running this on a Mac.