question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

autoUpdater.autoInstallOnAppQuit not working?

See original GitHub issue
  • Version: 20.28.4

electron-updater 3.1.2

  • Target: Mac, Windows, Linux

I’ve set autoUpdater.autoInstallOnAppQuit to false, and confirmed that after an update is downloaded (at the event handler) and the user opts not to .quitAndInstall(), the app will still install the update when it’s quit.

Digging through the code this was not expected as BaseUpdater/addQuitHandler should bail if the flag is false. https://github.com/electron-userland/electron-builder/blob/f966f1a22bd7577e493595ac261e4b38ec0ce233/packages/electron-updater/src/BaseUpdater.ts#L65

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:13 (1 by maintainers)

github_iconTop GitHub Comments

2reactions
stuartbrussell-intuitcommented, Jan 21, 2020

I’m seeing this with electron-updater 4.2.0, but only on Windows. On macOS it works as expected.

2reactions
jmeinkecommented, Jul 15, 2019

@develar This should be reopened IMO.

The issue orrcurs to them: https://github.com/Automattic/simplenote-electron/issues/1094 And it also happens to us with electron-updater v4.0.10 and autoUpdater.autoInstallOnAppQuit = false. When the user chooses to install the update and clicks “Later” on the update dialog, the new version of the app is installed without further notification after restarting the app twice.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to use the electron-updater.autoUpdater ... - Snyk
Secure your code as it's written. Use Snyk Code to scan source code in minutes - no build needed - and fix issues...
Read more >
node.js - When the new version is downloaded, the 'update ...
I'm new to electron and I have the following problem: "electron-log": "^2.2.17", ... autoInstallOnAppQuit = true; autoUpdater.
Read more >
Auto Update - electron-builder
* autoInstallOnAppQuit = true Boolean - Whether to automatically install a downloaded update on app quit (if quitAndInstall was not called before). * ......
Read more >
Electron控制应用是否更新 - 掘金
表示下载包不自动更新 autoUpdater.autoInstallOnAppQuit = false 在update-downloaded钩子中弹出对话框autoUpdater.on('update-downloaded', (ev, ...
Read more >
electron-updater@5.3.0 - jsDocs.io
autoInstallOnAppQuit : boolean;. Whether to automatically install a downloaded update on app quit (if quitAndInstall was not called before).
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found