Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Blank shortcut icon on windows, nsis

See original GitHub issue

Version: 19.46.4, 19.52.1

Target: windows 10, windows 7

HI. I try to build package via nsis on windows 10. After installation, I see blank shortcut icon on desktop. When i click on shortcut properties, in the fieldset Start in folder I see part of description text from my package.json When I click change icon it writes System windows is unable to find “part of description here”. So it seems, that the path of icon is set as part of description text. I don’t know, where the problem is.

Image: You can see the blank shortcut image and shortcut properties: electron-builder-bug

My package.json is:

  "name": "<deleted>",
  "version": "1.0.0",
  "description": "<deleted>",
  "main": "index.js",
  "scripts": {
    "start:dev1": "node ./node_modules/webpack-dev-server/bin/webpack-dev-server.js",
    "start:dev2": "node server.js",
    "electron": "electron .",
    "start": "electron .",
    "pack": "electron-builder --dir",
    "dist": "webpack && electron-builder --mac",
    "build": "webpack"
  },
  "repository": {
    "type": "git",
    "url": "<deleted>"
  },
  "author": "<deleted>",
  "license": "ISC",
  "homepage": "<deleted>",
  "build": {
    "protocols": {
      "name": "<deleted>",
      "schemes": [
        "<deleted>"
      ]
    },
    "asarUnpack": [
      "**/*"
    ],
    "files": [
      "build/icon.icns",
      "build/icon.ico",
      "build/icons/*.png",
      "build/nsh-plugins",
      "build/installer.nsh",
      "!uploads/*.mp4",
      "uploads/index.html",
      "binaries/${os}/${arch}/node.exe",
      "binaries/${os}/${arch}/node",
      "dist/bundle.js",
      "src",
      "electron",
      "nodejs_server",
      "*.html",
      "*.js",
      "*.tpl",
      "*.sh",
      "*.json",
      "*.md",
      "*.lock"
    ],
    "extraResources": [
      "node_modules/electron"
    ],
    "appId": "<deleted>",
    "nsis": {
      "oneClick": true,
      "perMachine": true,
      "artifactName": "${productName}_setup_${version}.${ext}"
    },
    "dmg": {
      "iconSize": 80,
      "contents": [
        {
          "x": 110,
          "y": 150
        },
        {
          "x": 240,
          "y": 150,
          "type": "link",
          "path": "/Applications"
        }
      ]
    },
    "deb": {
      "afterInstall": "linux_postinstall.tpl"
    },
    "win": {
      "icon": "build/icon.ico",
      "target": "NSIS"
    },
    "mac": {
      "category": "public.app-category.video",
      "target": "dmg",
      "icon": "build/icon.icns"
    },
    "linux": {
      "icon": "build/icons",
      "category": "AudioVideo",
      "desktop": {
        "Icon": "/opt/<deleted>/resources/app.asar.unpacked/build/icons/64x64.png"
      },
      "target": [
        "deb"
      ]
    }
  },
  "devDependencies": {
    "electron": "^1.7.9",
    "electron-builder": "^19.46.4",
    "webpack": "^3.10.0"
  },
  "dependencies": {
    "asar": "^0.14.0",
    "aws-sdk": "^2.164.0",
    "axios": "^0.17.1",
    "babel-core": "^6.2.1",
    "babel-loader": "^6.2.0",
    "babel-preset-es2015": "^6.1.18",
    "babel-preset-react": "^6.1.18",
    "babel-preset-stage-1": "^6.1.18",
    "bonjour": "^3.5.0",
    "chai": "^3.5.0",
    "chai-jquery": "^2.0.0",
    "cross-spawn": "^5.1.0",
    "domify": "^1.4.0",
    "electron-is-dev": "^0.3.0",
    "electron-log": "^2.2.12",
    "electron-redux": "^1.3.1",
    "ffmpeg-static": "^2.0.0",
    "ffprobe-electron": "^1.1.2",
    "ffprobe-static": "^2.0.0",
    "fluent-ffmpeg": "^2.1.2",
    "formidable": "^1.1.1",
    "http-server": "^0.10.0",
    "jquery": "^2.2.1",
    "jsdom": "^8.1.0",
    "lodash": "^3.10.1",
    "mime": "^2.0.3",
    "mocha": "^2.4.5",
    "opn": "^5.1.0",
    "react": "^0.14.3",
    "react-addons-test-utils": "^0.14.7",
    "react-dom": "^0.14.3",
    "react-modal": "^3.1.2",
    "react-redux": "4.3.0",
    "react-router": "^4.0.0",
    "react-router-dom": "^4.0.0",
    "recordrtc": "^5.4.5",
    "redux": "^3.1.0",
    "redux-devtools": "^3.4.1",
    "redux-devtools-dock-monitor": "^1.1.2",
    "redux-devtools-log-monitor": "^1.4.0",
    "redux-form": "^6.6.3",
    "redux-promise": "^0.5.3",
    "strip-ansi": "^4.0.0",
    "webpack-dev-server": "^2.9.4",
    "websocket": "^1.0.25"
  }
}

My installer.nsh script is:


!macro customInstall
  AccessControl::GrantOnFile "$INSTDIR\resources\app.asar.unpacked\uploads" "(S-1-5-32-545)" "FullAccess"

  DetailPrint "Register <deleted> URI Handler"
  DeleteRegKey HKCR "<deleted>"
  WriteRegStr HKCR "<deleted>" "" "URL:<deleted>"
  WriteRegStr HKCR "<deleted>" "URL Protocol" ""
  WriteRegStr HKCR "<deleted>\DefaultIcon" "" "$INSTDIR\${APP_EXECUTABLE_FILENAME}"
  WriteRegStr HKCR "<deleted>\shell" "" ""
  WriteRegStr HKCR "<deleted>\shell\Open" "" ""
  WriteRegStr HKCR "<deleted>\shell\Open\command" "" "$INSTDIR\${APP_EXECUTABLE_FILENAME} %1"
!macroend

Thanks, Martin