question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Can't use asar with yarn workspaces and hoisted deps anymore in Windows

See original GitHub issue
  • Version: 20.15.3, which is on “next” and I think represents master right now
  • Target: Windows

The PR https://github.com/electron-userland/electron-builder/pull/2948 tried to fix missing files when the electron app is a sub-package and yarn workspaces hoisted modules into the root dir. That PR still works for me, but the PR was closed in favor of this commit: https://github.com/electron-userland/electron-builder/commit/c31f6a1e6dd83cbf7170b89cf228f73c00a650ca

I don’t really understand why there are so many changes in that commit. Many of them seem unrelated. But the current code only works if asar is disabled. When it’s disabled, it correctly builds with the right files, but when enabled I get the following error:

screen shot 2018-05-29 at 11 23 05 am

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:4
  • Comments:13 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
jlongstercommented, Jun 13, 2018

@develar So to keep pinging you, but I’m happy to help find a fix, it’s just really hard to do it on my own because the changeset on the commit is so big. Any chance you could steer me in the right direction?

This will be the last time I ping you - otherwise I guess I’ll try to figure it out on my own.

0reactions
stale[bot]commented, Jul 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Yarn workspace not hoisting dependencies correctly #7572
Yarn workspace seems to be counting the references from external modules to decide whether to hoist a module or not.
Read more >
Workspaces - Yarn
Workspaces are a new way to set up your package architecture that's available by default starting from Yarn 1.0. It allows you to...
Read more >
Three simple tricks to speed up yarn install - Developer way
Those tricks can speed up your yarn install by up to 50%
Read more >
Introducing Yarn 2 ! - DEV Community ‍ ‍
This isn't the case anymore as the workspace-tools plugin extends Yarn, allowing you to do just that: $ yarn workspaces foreach run build....
Read more >
Why Are You Still Using Yarn in 2018? - I Am Turns
1 installed, and Brenda has Yarn v1.2. As they install and remove dependencies on a project, Yarn writes to a yarn.lock file. But...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found