question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Do not add ` "x-amz-acl": "public-read"` to the header when uploading artefacts to S3 bucket

See original GitHub issue
  • Version: 18.3.0
  • Electron-Updater: 2.0.0
  • Target: OSX/Windows

We have to allow the s3:PutObjectAcl in the IAM policy for the electron-builder to be able to successfully upload the artefacts to the S3 bucket, since it always adds a header "x-amz-acl": "public-read" with each upload request - trying to mark every object it uploads to the bucket as publicly readable. I suggest that this behaviour should be optional - and not the default one, since one can also achieve the same effect with appropriately crafted S3 bucket policy - which we actually prefer to. Another use case is when an S3 bucket with the built artefacts should not be publicly accessible at all.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

3reactions
develarcommented, Jul 12, 2017

19.16.0 — you can set acl to null to disable adding. Will be released today.

0reactions
romanrevcommented, Jul 12, 2017

thanks, much appreciated for your speedy resolution of the issue!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Uploading local artifacts to an S3 bucket - AWS CloudFormation
Use the AWS CloudFormation aws cloudformation package command to upload local artifacts that are referenced by a template.
Read more >
Working with Buckets in Amazon S3 - WSO2 Documentation
When calling init before this operation, the following headers should be removed: xAmzAcl, x AmzGrantRead, xAmzGrantWrite, xAmzGrantReadAcp, ...
Read more >
CodeBuild upload build artifact to S3 with ACL - Stack Overflow
Lets say A and B. Account A uses CodeBuild to build and upload artifacts to an S3 bucket owned by B. B account...
Read more >
put-object — AWS CLI 2.9.8 Command Reference
When you use this header, Amazon S3 checks the object against the provided MD5 value and, if they do not match, returns an...
Read more >
Deploying to Amazon S3 bucket - AppVeyor
Unpack zip artifacts and upload their contents as individual blobs ( unzip ) - Optional. Default is false . Remove all bucket/folder files...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found