question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Don't build when CI run is a pull request

See original GitHub issue
  • Version: 15.3.0

It would be nice if electron-builder didn’t try to build when the CI run is a pull request. The required codesign environment variables are not available on untrusted builds on Travis:

Encrypted variables are not available to untrusted builds such as pull requests coming from another repository.

I know I could turn off building on pull requests in the Travis repo settings, but I still want to do linting on pull requests.

Here’s how it’s currently failing: https://travis-ci.org/sindresorhus/caprine/jobs/210320431

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
sindresorhuscommented, Apr 20, 2017

@djalmaaraujo The issue description clearly describes why it was added. If you have other needs, open a separate issue and @develar might add an opt-in, but it’s not a good default.

0reactions
develarcommented, Apr 20, 2017

It is not issue, it is security feature. On CircleCI you also can disable secret passing. As suggested above, please file issue to add option.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Run the CI Pipeline during a Pull Request
I will show in this post how to protect the master branch with a policy that enforces a pull request, reviews, and run...
Read more >
Pull requests not triggering build - CircleCI Discuss
You can't trigger a build with a pull request unfortunately, not that I know of. The reason is, because there is no commit...
Read more >
Don't trigger builds for branches that already have a pull ...
The pipeline is configured to run a build whenever a change is pushed to a feature branch. This is desired for quick feedback....
Read more >
Why your team doesn't need to use pull requests
Github introduced the pull request practice, and features to support it, to make it easier for people who run open-source projects to accept ......
Read more >
Building Pull Requests - Travis CI Docs
How Pull Requests are Built #. When a pull request is opened on GitHub, Travis CI receives a notification and runs a build....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found