iconUrl parameter isn't working
See original GitHub issueWhen I’m trying to build package for windows with iconUrl
property(like documentation says) it fails by trying to retrieve file from default location. Seems like there is no check for specific icon - source.
Output:
➜ pomodoro git:(master) npm run package
> pomodoro@2.0.0 package /Users/g07cha/Projects/pomodoro
> build -w
Skip app dependencies rebuild because dev and app dependencies are not separated
Error: ENOENT: no such file or directory, open '/Users/g07cha/Projects/pomodoro/build/icon.ico'
at Error (native)
From previous event:
at /Users/g07cha/Projects/pomodoro/node_modules/electron-builder/src/winPackager.ts:126:24
at undefined.next (native)
From previous event:
at tsAwaiter (/Users/g07cha/Projects/pomodoro/node_modules/electron-builder/src/awaiter.ts:10:47)
at Object.build (/Users/g07cha/Projects/pomodoro/node_modules/electron-builder/src/builder.ts:182:52)
at Object.<anonymous> (/Users/g07cha/Projects/pomodoro/node_modules/electron-builder/src/build-cli.ts:8:28)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
at Function.Module.runMain (module.js:575:10)
at startup (node.js:160:18)
at node.js:445:3
Part of “package.json” file, you could see whole file here
"build": {
"productName": "Pomodoro",
"app-bundle-id": "com.g07cha.pomodoro",
"app-category-type": "public.app-category.productivity",
"osx": {
"background": "build/background.png",
"icon": "build/icon.icns",
"contents": [
{
"x": 320,
"y": 250,
"type": "link",
"path": "/Applications"
},
{
"x": 70,
"y": 250,
"type": "file"
}
]
},
"win": {
"iconUrl": "https://github.com/G07cha/pomodoro/blob/master/icons/icon.ico?raw=true"
}
Issue Analytics
- State:
- Created 7 years ago
- Comments:11 (5 by maintainers)
Top Results From Across the Web
Unable to use Custom Icons in Leaflet - Stack Overflow
I am not exactly sure where the IconURL is being set inside the leaflet, does anyone have any idea what I am doing...
Read more >URL Icon NOT Working with URLs which Contain Parameters
Solved: Hi. trying to create this table with "URL Icon" enabled, the result is still: Those URLs still don't get converted to links...
Read more >iconUrl vs icon_url [#2923602] | Drupal.org
The problem is that with one patch views works well, but field formatter is broken, and with other patch everything happens vice versa....
Read more >Variable iconUrl in Leaflet, use GEOJson property voor ...
This happens because Leaflet event handler functions are expected to receive just one parameter (the event). Do not expect computer code to ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@dmdewey Squirrel.windows is deprecated, please use NSIS. #529 is ready to close.
Thanks for you investigation and comment.
A lot of people can ask only WTF when
iconUrl
is required to be http link. It is one of the reasons why Squirrel.Windows is deprecated and NSIS will be default target for windows soon.@develar oh, now I understand how it works, thank you, but again, I think we need to specify it in documentation.