Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

macOS pkg written to same filename for x64 and arm64

See original GitHub issue

Version: 22.10.5
Electron Version: 12.0.5
Electron Type (current, beta, nightly): current
Target: macOS pkg for x64 and arm64

electron-builder --mac pkg --x64 --arm64 builds both the x64 pkg and the arm64 pkg, but it writes them both to the same filename Zulip-5.6.0.pkg, so the latter immediately overwrites the former.

  • building        target=pkg arch=x64 file=dist/Zulip-5.6.0.pkg
…
  • building        target=pkg arch=arm64 file=dist/Zulip-5.6.0.pkg

I would expect the latter to go to Zulip-5.6.0-arm64.pkg, as already happens with DMG and zip.

Issue Analytics

State:
Created 2 years ago
Comments:5

Top GitHub Comments

1reaction

anderskcommented, May 3, 2021

Yeah, that works for me.

  • building        target=pkg arch=x64 file=dist/Zulip-5.7.0.pkg
…
  • building        target=pkg arch=arm64 file=dist/Zulip-5.7.0-arm64.pkg

0reactions

mmaiettacommented, May 3, 2021

Big thanks for the gist! Wish other tickets had those provided more often 🙂

I added the arch/pkg args to the build config and it repro’d there as well. Found the issue seems to only exist with pkg target. I tested zip and dmg too and both worked correctly.

I think I was able to identify the fix, can you try out this patch? File: app-builder-lib+22.10.5.patch

diff --git a/node_modules/app-builder-lib/out/targets/pkg.js b/node_modules/app-builder-lib/out/targets/pkg.js
index 9a53e36..abd8215 100644
--- a/node_modules/app-builder-lib/out/targets/pkg.js
+++ b/node_modules/app-builder-lib/out/targets/pkg.js
@@ -115,7 +115,7 @@ class PkgTarget extends _core().Target {
     const options = this.options;
     const appInfo = packager.appInfo; // pkg doesn't like not ASCII symbols (Could not open package to list files: /Volumes/test/t-gIjdGK/test-project-0/dist/Test App ßW-1.1.0.pkg)
 
-    const artifactName = packager.expandArtifactNamePattern(options, "pkg");
+    const artifactName = packager.expandArtifactNamePattern(options, "pkg", arch);
     const artifactPath = path.join(this.outDir, artifactName);
     await packager.info.callArtifactBuildStarted({
       targetPresentableName: "pkg",