NSIS: Auto-updating leaves a bad shortcut when a user attaches the icon to the Windows Taskbar
See original GitHub issue- Version: Electron-builder: 8.6.0
- Target: Windows NSIS
User Story
As a Electron-App user, I would like my pinned Taskbar icon to still work after updating, so I can quickly use my app after updates and reduce time spent pinning the icon to my Taskbar after every update.
Current situation:
When you do auto-update, it installs it in a new folder, deletes the old folder, and leaves the pinned Taskbar icon referencing a folder that doesn’t exist.
Example workflow:
### User side:
1. user has electron app on Windows Taskbar.
2. User runs electron app on 2.0.21. It is installed in C:\Program Files\electron-app\2.0.21\electron-app.exe
3. User boots up the app.
4. User gets install prompt. Accepts it.
5. The app downloads.
### Electron-App:
* Creates a new folder 2.0.22.
* Installs Electron-app in the 2.0.22.
* Deletes folder 2.0.21.
* leaves the dock icon referencing a folder and .exe that doesn't exist.
Ideal situation:
When you do an auto-update, the pinned Taskbar icon continues to work.
Assumptions:
Currently Electron-App structure is: Program_Files\Electron-App-Name\Version\Electron-App.exe
Uninstalling is easy because it uninstalls the entire Version
folder.
Potential Proposal:
Move the .exe outside of the version folder? Electron-App Structure:
- Program_files\Electron-App-Name\Electron-App.exe
- Program_files\Electron-App-Name\Version\Electron-App files (including uninstall)
Note: The above proposal is just a suggestion, I am open to whatever the best technical implementation is (I trust you know better than me).
References: #884
Issue Analytics
- State:
- Created 7 years ago
- Reactions:8
- Comments:12 (4 by maintainers)
Top GitHub Comments
Fixed (If
allowToChangeInstallationDirectory
is not set totrue
). Thanks to @MariaDimaHi! Is there any workaround for this issue?