Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[NSIS] `runAfterFinish: false` not working when `oneClick: true`

See original GitHub issue

Version: 20.14.7
Target: NSIS

For quite some time I had:

oneClick: true,
runAfterFinish: false

as I want to build a simple installer but I need the app to not start at the end. I see that from 20.13.5 the runAfterFinish(RUN_AFTER_FINISH) is not taken into account: https://github.com/electron-userland/electron-builder/commit/edb82afd328e51fe736da92cd389b5061bdf6318

I did check the corresponding tasks for this PR but I do not get the picture what exactly was fixed there and whether removing runAfterFinish was intended or not.

Anyway let me know if we can restore it, or how can I achieve the previous effect 🙂

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

develarcommented, May 25, 2018

20.15.1

0reactions

wojtkowiakcommented, May 28, 2018

About the first issue, it gets stuck here: await executeAppBuilder(["node-dep-tree", "--dir", platformPackager.info.appDir])

Probably this should not be invoked at all as I do not have node_modules at this point. Can I do a PR with a similar check for node_modules like we did here? (I guess I can just add it to this if)

Top Results From Across the Web

NSIS - electron-builder

If oneClick is true (default): Whether to install per all users (per-machine). If oneClick is false and perMachine is true : no install...

Electron.js NSIS installer - "oneClick": false has no effect ...

I put the "nsis" options inside the "build" options and it worked.

Distributing Electron Applications : Building NSIS Installers

This playlist/video has been uploaded for Marketing purposes and contains only selective videos. For the entire video course and code, ...

package.json · ea456ff8840114e0ec65bc26b43f708a4d3d4708 ...

... "linux": { "icon": "build/icons" }, "nsis": { "oneClick": false, "allowToChangeInstallationDirectory": true, "perMachine": true, "runAfterFinish": false } ...

Source - GitHub

... /electron-userland/electron-builder/issues/1743) * **nsis:** option to not ... Features * **nsis:** NSIS with oneClick set to true does not relaunch the ...