nsis-web and nsis, public GitHub: Electron-updater don't start downloading after update-available

After autoUpdater.checkForUpdates(), it emmits update-available but don’t start downloading. I’m using GitHub to publish.

---

• Electron-updater - Version: 2.17.3
• Electron-builder - Version: 19.48.3
• Target: Windows | nsis-web

[aenario]

Hello @develar I just debugged a similar issue and it seem to be related to redirection.

May be it’s only for big bundles, but github is redirecting to amazonS3, which is not followed by electron’s net package because of the the redirect: “manual”.

I am not sure why you need to manually deal with redirection in this package, and I am confused by the structure between Provider <-> Executor <-> Updater and so on, so I won’t be pushing a PR. However, I got it fixed with this hacky monkey patch :

const _mp = autoUpdater.httpExecutor.doRequest
    autoUpdater.httpExecutor.doRequest = function (options, callback) {
        const req = _mp.call(this, options, callback)
        req.on('redirect', () => req.followRedirect())
        return req
    }

Hope that helps to pinpoint the issue and solve it more definitively.

[gordonshieh]

I did some sleuthing, and found that in BaseUpdater.js:87 of electron-builder const destinationFile = _path.join(tempDir, _path.posix.basename(fileInfo.url.pathname)); should be: const destinationFile = _path.join(tempDir, _path.posix.basename(fileInfo.info.url));

That will download the installer with the proper filename. I just found the fix, so I can’t exactly have a clean slate that is reproducible for submitting a new PR.

Electron 1.7.9 Electron-builder 19.49.0