snap fails to process with "bin/desktop-launch $SNAP/app/my-app does not exist lint-snap-v2_command"

• Version: 20.0.7

• Target: build --linux --x64

Now that https://github.com/electron-userland/electron-builder/issues/2596 has been resolved I have tried pushing a packaged .snap for our app again.

The snap successfully uploads this time, yet it now fails the validation process with the following:

1 Warning:
unknown fields for app 'my-app': 'adapter' lint-snap-v2_apps_unknown (my-app) 

1 Fail:
bin/desktop-launch $SNAP/app/my-app does not exist lint-snap-v2_command (my-app) 

and 60 passes…

[jdstrand]

@kspearrin - please see my last comment for ‘adapter’.

The issue with bin/desktop-launch $SNAP/app/my-app does not exist lint-snap-v2_command (my-app) is a bug in our review tools, which I’ll fix. If you request a manual review, I’ll approve it (though see below).

If you remove adapter: none from your snapcraft.yaml, this will pass again. What is happening is that with adapter: none a command wrapper is used in the resulting meta/snap.yaml such that it has command: command-tusk.wrapper, which passes review. With the new adapter: none yaml, snapcraft passes the command unmodified from snapcraft.yaml to meta/snap.yaml (ie bin/desktop-launch $SNAP/app/my-app) and the review tools aren’t splitting on spaces and so it treats the command as bin/desktop-launch $SNAP/app/my-app when it should be bin/desktop-launch.

[jdstrand]

The ‘adapter’ issue is a bug in snapcraft: https://bugs.launchpad.net/snapcraft/+bug/1750658. It looks like @kalikiana started to look at it.