Unable to override "https://electronjs.org/headers" during electron-builder install-app-deps
See original GitHub issue- electron-builder Version: 22.10.5
- Electron Version: 11.3.x
- Electron Type (current, beta, nightly): current
- Target: win
It is not possible to override npm_config_disturl
during electron-builder install-app-deps
this setting depends on some weird (for me) parameter useCustomDist
But as I have checked this parameter is always true:
https://github.com/search?q=org%3Aelectron-userland+useCustomDist&type=code
It is important for me to fast fix this, but I am not sure how it should be changed properly (without breaking changes to projects using it).
Why I need this change?
I have an environment with restricted network access rules. So I am getting:
gyp verb created nodedir C:\Users\Administrator\.electron-gyp\11.3.0
gyp http GET https://electronjs.org/headers/v11.3.0/node-v11.3.0-headers.tar.gz
gyp WARN install got an error, rolling back install
I have downloaded all needed files to our secure repository, but I am unable to make it work with the new dist-url.
Issue Analytics
- State:
- Created 2 years ago
- Comments:5
Top GitHub Comments
It looks like you can override it via
process.env
https://github.com/electron-userland/electron-builder/blob/a879ba7f02ea704084b9672d6b9c9a47b7e5c27d/packages/app-builder-lib/src/util/yarn.ts#L44-L54For a quick solution, just add a patch locally to set
useCustomDist
to false and then usepatch-package
to persist it acrossnpm install
s? https://github.com/electron-userland/electron-builder/blob/a879ba7f02ea704084b9672d6b9c9a47b7e5c27d/packages/electron-builder/src/cli/install-app-deps.ts#L63Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.