Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Universal NSIS setup file for x64+arm64 (WoA) is broken

See original GitHub issue

Universal NSIS setup file for x64+arm64 (Windows on ARM) is broken. Instead of installing the app, it wipes out the whole program directory, and copies only the Uninstall ....exe file (tested on x64 devices).

Is this change ready? The PR that tried to revert this is closed: #4416 but when I tried to add arm64 support to my app, the universal-arch NSIS doesn’t seem to work correctly on my x64 system. It only installs the Uninstall {...}.exe and ignores everything else.

Capture

_Originally posted by @quanglam2807 in https://github.com/electron-userland/electron-builder/issues/4228#issuecomment-741517647_

Issue Analytics

State:
Created 3 years ago
Reactions:3
Comments:16 (6 by maintainers)

Top GitHub Comments

2reactions

lutzroedercommented, Jan 19, 2021

@mmaietta works for x64+arm64 on both Windows x64 and Windows ARM. @gnattu can you try as well?

1reaction

quanglam2807commented, Jan 15, 2021

@lutzroeder #4416 was not merged so #4228 changes remain intact and not reverted.

I think we should try to fix extractAppPackage.nsh as @gnattu mentioned above. Unlike macOS, electron-builder opts to use universal binary on Windows so there’s no way to build independent arm64 and x64 setup files in one build process. I think we should also make this consistent with macOS by adding Arch.universal support to Windows but it’s not a simple task.